From: Michal Hocko <mhocko@suse.cz>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] memcg: oom: fix totalpages calculation for swappiness==0
Date: Mon, 15 Oct 2012 16:47:36 +0200 [thread overview]
Message-ID: <20121015144736.GI29069@dhcp22.suse.cz> (raw)
In-Reply-To: <CAHGf_=p4d33t7i5++YHTkc0PbAUckca1oBxR5dZ48EzybKYHgw@mail.gmail.com>
On Mon 15-10-12 10:25:14, KOSAKI Motohiro wrote:
> > diff --git a/Documentation/sysctl/vm.txt b/Documentation/sysctl/vm.txt
> > index 078701f..308fd77 100644
> > --- a/Documentation/sysctl/vm.txt
> > +++ b/Documentation/sysctl/vm.txt
> > @@ -640,6 +640,9 @@ swappiness
> > This control is used to define how aggressive the kernel will swap
> > memory pages. Higher values will increase agressiveness, lower values
> > decrease the amount of swap.
> > +The value can be used from the [0, 100] range, where 0 means no swapping
> > +at all (even if there is a swap storage enabled) while 100 means that
> > +anonymous pages are reclaimed in the same rate as file pages.
>
> I think this only correct when memcg. Even if swappiness==0, global reclaim swap
> out anon pages before oom.
Right you are (we really do swap when the file pages are really
low)! Sorry about the confusion. I kind of became if(global_reclaim)
block blind...
Then this really needs a memcg specific documentation fix. What about
the following?
---
next prev parent reply other threads:[~2012-10-15 14:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 14:11 Michal Hocko
2012-10-10 20:50 ` David Rientjes
2012-10-11 8:50 ` Michal Hocko
2012-10-11 8:57 ` [PATCH] memcg: oom: fix totalpages calculation for memory.swappiness==0 Michal Hocko
2012-10-11 9:13 ` Michal Hocko
2012-10-11 12:20 ` Johannes Weiner
2012-10-12 13:01 ` Michal Hocko
2012-10-11 22:36 ` KOSAKI Motohiro
2012-10-12 13:01 ` Michal Hocko
2012-10-15 22:04 ` [PATCH v2] " Michal Hocko
2012-10-15 22:07 ` [PATCH] doc: describe memcg swappiness more precisely memory.swappiness==0 Michal Hocko
2012-10-16 0:51 ` Kamezawa Hiroyuki
2012-10-16 0:54 ` David Rientjes
2012-11-07 22:10 ` [PATCH v2] memcg: oom: fix totalpages calculation for memory.swappiness==0 Andrew Morton
2012-11-07 22:46 ` Michal Hocko
2012-11-07 22:53 ` Andrew Morton
2012-11-08 8:35 ` Michal Hocko
2012-10-15 9:11 ` [RFC PATCH] memcg: oom: fix totalpages calculation for swappiness==0 Kamezawa Hiroyuki
2012-10-15 9:49 ` Michal Hocko
2012-10-15 14:25 ` KOSAKI Motohiro
2012-10-15 14:47 ` Michal Hocko [this message]
2012-10-15 22:33 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121015144736.GI29069@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox