From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx104.postini.com [74.125.245.104]) by kanga.kvack.org (Postfix) with SMTP id 3363C6B002B for ; Wed, 10 Oct 2012 10:33:37 -0400 (EDT) Date: Wed, 10 Oct 2012 22:33:31 +0800 From: Fengguang Wu Subject: Re: [patch for-linus] memcg, kmem: fix build error when CONFIG_INET is disabled Message-ID: <20121010143331.GA7880@localhost> References: <5075383A.1000001@parallels.com> <20121010092700.GD23011@dhcp22.suse.cz> <50753FFF.6060102@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50753FFF.6060102@parallels.com> Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: Michal Hocko , David Rientjes , Andrew Morton , Linus Torvalds , Randy Dunlap , KAMEZAWA Hiroyuki , "Kirill A. Shutemov" , "David S. Miller" , "Eric W. Biederman" , Eric Dumazet , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Wed, Oct 10, 2012 at 01:29:35PM +0400, Glauber Costa wrote: > On 10/10/2012 01:27 PM, Michal Hocko wrote: > > On Wed 10-10-12 12:56:26, Glauber Costa wrote: > >> On 10/10/2012 10:32 AM, David Rientjes wrote: > >>> Commit e1aab161e013 ("socket: initial cgroup code.") causes a build error > >>> when CONFIG_INET is disabled in Linus' tree: > >>> > >> unlikely that something that old would cause a build bug now, specially > >> that commit, that actually wraps things inside CONFIG_INET. > >> > >> More likely caused by the recently merged > >> "memcg-cleanup-kmem-tcp-ifdefs.patch" in -mm by mhocko (CC'd) > > > > Strange it didn't trigger during my (and Fenguang) build testing. > > Fengguang mentioned to me while testing my kmemcg tree that were a build > error occurring in the base tree, IOW, yours. Yes, and the errors were sent to/cc Michal and kernel-janitors@vger.kernel.org > Fengguang, was that this error? Why hasn't it showed up before in the > test system? I do find this error in the build error log: (.text+0x867f): undefined reference to `sock_update_memcg' 2012-09-24 04:54:53 snb next:akpm:69921c3 x86_64-randconfig-s005 0a7f618 Unfortunately it was not reported because the build system could miss/ignore build bugs due to various reasons/imperfections. It has since then undergo lots of enhancements and as a result, the daily reported errors have more than doubled. :-) Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org