From: Andrew Morton <akpm@linux-foundation.org>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, mhocko@suse.cz, kirill@shutemov.name,
Andrea Arcangeli <aarcange@redhat.com>,
Chris Metcalf <cmetcalf@tilera.com>,
Steve Capper <steve.capper@arm.com>
Subject: Re: [PATCH v2] mm: thp: Set the accessed flag for old pages on access fault.
Date: Tue, 2 Oct 2012 15:01:04 -0700 [thread overview]
Message-ID: <20121002150104.da57fa94.akpm@linux-foundation.org> (raw)
In-Reply-To: <1349197151-19645-1-git-send-email-will.deacon@arm.com>
On Tue, 2 Oct 2012 17:59:11 +0100
Will Deacon <will.deacon@arm.com> wrote:
> On x86 memory accesses to pages without the ACCESSED flag set result in the
> ACCESSED flag being set automatically. With the ARM architecture a page access
> fault is raised instead (and it will continue to be raised until the ACCESSED
> flag is set for the appropriate PTE/PMD).
>
> For normal memory pages, handle_pte_fault will call pte_mkyoung (effectively
> setting the ACCESSED flag). For transparent huge pages, pmd_mkyoung will only
> be called for a write fault.
>
> This patch ensures that faults on transparent hugepages which do not result
> in a CoW update the access flags for the faulting pmd.
Alas, the code you're altering has changed so much in linux-next that I
am reluctant to force this fix in there myself. Can you please
redo/retest/resend? You can do that on 3.7-rc1 if you like, then we
can feed this into -rc2.
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3524,7 +3524,8 @@ retry:
>
> barrier();
> if (pmd_trans_huge(orig_pmd)) {
> - if (flags & FAULT_FLAG_WRITE &&
> + int dirty = flags & FAULT_FLAG_WRITE;
`flags' is `unsigned int', so making `dirty' match that is nicer.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-02 22:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 16:59 Will Deacon
2012-10-02 17:46 ` Andrea Arcangeli
2012-10-02 22:01 ` Andrew Morton [this message]
2012-10-03 9:09 ` Will Deacon
2012-10-17 13:01 ` Will Deacon
2012-10-17 15:26 ` David Miller
2012-10-17 15:54 ` Will Deacon
2012-10-18 22:05 ` Andrew Morton
2012-10-19 9:10 ` Will Deacon
2012-10-19 18:49 ` Andrew Morton
2012-10-22 10:35 ` Will Deacon
2012-10-22 18:18 ` Andrew Morton
2012-10-23 10:11 ` Will Deacon
2012-10-23 21:50 ` Andrew Morton
2012-10-24 9:35 ` Will Deacon
2012-10-04 22:13 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121002150104.da57fa94.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=cmetcalf@tilera.com \
--cc=kirill@shutemov.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=steve.capper@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox