From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx192.postini.com [74.125.245.192]) by kanga.kvack.org (Postfix) with SMTP id A40356B0069 for ; Tue, 4 Sep 2012 10:35:57 -0400 (EDT) Date: Tue, 4 Sep 2012 16:35:52 +0200 From: Michal Hocko Subject: Re: [PATCH v2] memcg: first step towards hierarchical controller Message-ID: <20120904143552.GB15683@dhcp22.suse.cz> References: <1346687211-31848-1-git-send-email-glommer@parallels.com> <20120903170806.GA21682@dhcp22.suse.cz> <5045BD25.10301@parallels.com> <20120904130905.GA15683@dhcp22.suse.cz> <504601B8.2050907@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <504601B8.2050907@parallels.com> Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Dave Jones , Ben Hutchings , Peter Zijlstra , Paul Turner , Lennart Poettering , Kay Sievers , Kamezawa Hiroyuki , Johannes Weiner , Tejun Heo On Tue 04-09-12 17:27:20, Glauber Costa wrote: > On 09/04/2012 05:09 PM, Michal Hocko wrote: > > Not really. Do it slowly means that somebody actually _notices_ that > > something is about to change and they have a lot of time for that. This > > will be really hard with the config option saying N by default. People > > will ignore that until it's too late. > > We are interested in those users who would keep the config default N and > > they are (ab)using use_hierarchy=0 in a way which is hard/impossible to > > fix. This is where distributions might help and they should IMHO but why > > to put an additional code into upstream? Isn't it sufficient that those > > who would like to help (and take the risk) would just take the patch? > > At least Fedora, seem to frown upon heavily at non-upstream patches. OK, so what about the following approach instead? We won't change the default but rather shout at people when they actually create subtrees with use_hierarchy==0. This shouldn't make pointless noise. I do not remember whether we have considered this previously so sorry if this was shot down as well. ---