From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx166.postini.com [74.125.245.166]) by kanga.kvack.org (Postfix) with SMTP id 588D46B0044 for ; Thu, 16 Aug 2012 05:53:15 -0400 (EDT) Date: Thu, 16 Aug 2012 11:53:09 +0200 From: Michal Hocko Subject: Re: [PATCH v2 06/11] memcg: kmem controller infrastructure Message-ID: <20120816095309.GB2817@dhcp22.suse.cz> References: <1344517279-30646-1-git-send-email-glommer@parallels.com> <1344517279-30646-7-git-send-email-glommer@parallels.com> <20120814172540.GD6905@dhcp22.suse.cz> <502B6F00.8040207@parallels.com> <20120815130952.GI23985@dhcp22.suse.cz> <502BABCF.7020608@parallels.com> <20120815142338.GL23985@dhcp22.suse.cz> <502BB1E1.5080403@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <502BB1E1.5080403@parallels.com> Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, devel@openvz.org, Johannes Weiner , Andrew Morton , kamezawa.hiroyu@jp.fujitsu.com, Christoph Lameter , David Rientjes , Pekka Enberg , Pekka Enberg On Wed 15-08-12 18:27:45, Glauber Costa wrote: > > >> > >> I see now, you seem to be right. > > > > No I am not because it seems that I am really blind these days... > > We were doing this in mem_cgroup_do_charge for ages: > > if (!(gfp_mask & __GFP_WAIT)) > > return CHARGE_WOULDBLOCK; > > > > /me goes to hide and get with further feedback with a clean head. > > > > Sorry about that. > > > I am as well, since I went to look at mem_cgroup_do_charge() and missed > that. I thought we are not doing atomic allocations in user pages accounting but I was obviously wrong because at least shmem uses atomic allocations for ages. > Do you have any other concerns specific to this patch ? I understood you changed also handle thingy. So the patch should be correct. Do you plan to send an updated version? -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org