From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx182.postini.com [74.125.245.182]) by kanga.kvack.org (Postfix) with SMTP id 9FD766B002B for ; Fri, 10 Aug 2012 08:51:05 -0400 (EDT) Date: Fri, 10 Aug 2012 14:51:02 +0200 From: Michal Hocko Subject: Re: [patch] hugetlb: correct page offset index for sharing pmd Message-ID: <20120810125102.GB1425@dhcp22.suse.cz> References: <20120803133235.GA8434@dhcp22.suse.cz> <20120810094825.GA1440@dhcp22.suse.cz> <20120810122730.GA1425@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Hillf Danton Cc: Mel Gorman , Andrew Morton , Linux-MM , LKML On Fri 10-08-12 20:37:20, Hillf Danton wrote: > On Fri, Aug 10, 2012 at 8:27 PM, Michal Hocko wrote: > > > > I guess you mean unmap_ref_private and that has been changed by you > > (0c176d5 mm: hugetlb: fix pgoff computation when unmapping page from > > vma)... I was wrong at that time when giving my Reviewed-by. The patch > > didn't break anything because you still find all relevant vmas because > > vma_hugecache_offset just provides a smaller index which is still within > > boundaries. > > No, as shown by the log message of 0c176d52b, that fix was > triggered by (vma->vm_pgoff >> PAGE_SHIFT), thus I dont see > what you really want to revert. fix for that would be a part of the revert of course. > > I think that 0c176d52 should be reverted because we do not have to refer > > to the head page in this case and as we can see it causes confusion. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org