From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx123.postini.com [74.125.245.123]) by kanga.kvack.org (Postfix) with SMTP id B229B6B002B for ; Fri, 10 Aug 2012 08:46:52 -0400 (EDT) Date: Fri, 10 Aug 2012 13:46:49 +0100 From: Mel Gorman Subject: Re: [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages Message-ID: <20120810124649.GL10288@csn.ul.ie> References: <20120809090019.GB10288@csn.ul.ie> <20120809144835.GA2719@t510.redhat.com> <20120809151218.GB2719@t510.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20120809151218.GB2719@t510.redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Rafael Aquini Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Rusty Russell , "Michael S. Tsirkin" , Rik van Riel , Andi Kleen , Andrew Morton , Konrad Rzeszutek Wilk , Minchan Kim On Thu, Aug 09, 2012 at 12:12:19PM -0300, Rafael Aquini wrote: > On Thu, Aug 09, 2012 at 11:48:36AM -0300, Rafael Aquini wrote: > > Sure! > > what do you think of: > > > > +/* putback_lru_page() counterpart for a ballooned page */ > > +void putback_balloon_page(struct page *page) > > +{ > > + lock_page(page); > > + if (!WARN_ON(!movable_balloon_page(page))) { > > + __putback_balloon_page(page); > > + put_page(page); > > + } > > + unlock_page(page); > > +} > > > Or perhaps > > +/* putback_lru_page() counterpart for a ballooned page */ > +void putback_balloon_page(struct page *page) > +{ > + if (!WARN_ON(!movable_balloon_page(page))) { > + lock_page(page); > + __putback_balloon_page(page); > + put_page(page); > + unlock_page(page); > + } > +} That should be fine. I find the WARN_ON construct odd to read but only because it's unusual. It is more typical to see something like if (WARN_ON(!movable_balooon_page(page))) return; lock_page(page); __putback_balloon_page(page); put_page(page); unlock_page(page); but either works. Do not forget to update the caller of course. Thanks. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org