From: Rafael Aquini <aquini@redhat.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Rusty Russell <rusty@rustcorp.com.au>,
"Michael S. Tsirkin" <mst@redhat.com>,
Rik van Riel <riel@redhat.com>, Andi Kleen <andi@firstfloor.org>,
Andrew Morton <akpm@linux-foundation.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages
Date: Thu, 9 Aug 2012 12:12:19 -0300 [thread overview]
Message-ID: <20120809151218.GB2719@t510.redhat.com> (raw)
In-Reply-To: <20120809144835.GA2719@t510.redhat.com>
On Thu, Aug 09, 2012 at 11:48:36AM -0300, Rafael Aquini wrote:
> Sure!
> what do you think of:
>
> +/* putback_lru_page() counterpart for a ballooned page */
> +void putback_balloon_page(struct page *page)
> +{
> + lock_page(page);
> + if (!WARN_ON(!movable_balloon_page(page))) {
> + __putback_balloon_page(page);
> + put_page(page);
> + }
> + unlock_page(page);
> +}
>
Or perhaps
+/* putback_lru_page() counterpart for a ballooned page */
+void putback_balloon_page(struct page *page)
+{
+ if (!WARN_ON(!movable_balloon_page(page))) {
+ lock_page(page);
+ __putback_balloon_page(page);
+ put_page(page);
+ unlock_page(page);
+ }
+}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-09 15:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 22:53 [PATCH v6 0/3] make balloon pages movable by compaction Rafael Aquini
2012-08-08 22:53 ` [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages Rafael Aquini
2012-08-09 1:37 ` Rik van Riel
2012-08-09 1:55 ` Minchan Kim
2012-08-09 9:00 ` Mel Gorman
2012-08-09 14:48 ` Rafael Aquini
2012-08-09 15:12 ` Rafael Aquini [this message]
2012-08-10 12:46 ` Mel Gorman
2012-08-08 22:53 ` [PATCH v6 2/3] virtio_balloon: introduce migration primitives to balloon pages Rafael Aquini
2012-08-09 1:39 ` Rik van Riel
2012-08-08 22:53 ` [PATCH v6 3/3] mm: add vm event counters for balloon pages compaction Rafael Aquini
2012-08-09 1:40 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120809151218.GB2719@t510.redhat.com \
--to=aquini@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan@kernel.org \
--cc=mst@redhat.com \
--cc=riel@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox