From: Arnd Bergmann <arnd@arndb.de>
To: David Rientjes <rientjes@google.com>
Cc: Pekka Enberg <penberg@kernel.org>,
Christoph Lameter <cl@linux.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Matt Mackall <mpm@selenic.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm/slob: avoid type warning about alignment value
Date: Wed, 11 Jul 2012 06:39:43 +0000 [thread overview]
Message-ID: <201207110639.43587.arnd@arndb.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1207101815580.684@chino.kir.corp.google.com>
On Wednesday 11 July 2012, David Rientjes wrote:
> Wouldn't it be better to avoid this problem more generally by casting the
> __alignof__ for ARCH_{KMALLOC,SLAB}_MINALIGN to int in slab.h? All
> architectures that define these themselves will be using plain integers,
> the problem is __alignof__ returning size_t when undefined.
I thought about it but I wasn't sure if that would cover all possible
cases. My version at least is known not to introduce a different type
mismatch on another architecture.
Also, size_t seems to be the correct type here, while the untyped
definition is just an int.
Arnd
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-11 6:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 20:55 Arnd Bergmann
2012-07-11 1:18 ` David Rientjes
2012-07-11 6:39 ` Arnd Bergmann [this message]
2012-07-11 20:42 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207110639.43587.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox