From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx200.postini.com [74.125.245.200]) by kanga.kvack.org (Postfix) with SMTP id 716466B0070 for ; Fri, 6 Jul 2012 01:19:28 -0400 (EDT) Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 6 Jul 2012 01:19:27 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id B941938C8056 for ; Fri, 6 Jul 2012 01:19:23 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q665JNPv362602 for ; Fri, 6 Jul 2012 01:19:23 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q665JMM3025568 for ; Fri, 6 Jul 2012 02:19:23 -0300 Date: Fri, 6 Jul 2012 13:19:16 +0800 From: Gavin Shan Subject: Re: [PATCH] mm/memcg: add BUG() to mem_cgroup_reset Message-ID: <20120706051916.GB29829@shangw> Reply-To: Gavin Shan References: <1341546297-6223-1-git-send-email-liwp.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1341546297-6223-1-git-send-email-liwp.linux@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Wanpeng Li Cc: Andrew Morton , Johannes Weiner , Michal Hocko , KAMEZAWA Hiroyuki , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Fri, Jul 06, 2012 at 11:44:57AM +0800, Wanpeng Li wrote: >From: Wanpeng Li > >Branch in mem_cgroup_reset only can be RES_MAX_USAGE, RES_FAILCNT. > >Signed-off-by: Wanpeng Li >--- > mm/memcontrol.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > >diff --git a/mm/memcontrol.c b/mm/memcontrol.c >index a501660..5e4d1ab 100644 >--- a/mm/memcontrol.c >+++ b/mm/memcontrol.c >@@ -3976,6 +3976,8 @@ static int mem_cgroup_reset(struct cgroup *cont, unsigned int event) > else > res_counter_reset_failcnt(&memcg->memsw); > break; >+ default: >+ BUG(); It might be not convinced to have "BUG()" here. You might add something for debugging purpose. For example, default: printk(KERN_WARNING "%s: Unrecognized name %d\n", __func__, name); Thanks, Gavin > } > > return 0; >-- >1.7.5.4 > >-- >To unsubscribe, send a message with 'unsubscribe linux-mm' in >the body to majordomo@kvack.org. For more info on Linux MM, >see: http://www.linux-mm.org/ . >Don't email: email@kvack.org > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org