From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx151.postini.com [74.125.245.151]) by kanga.kvack.org (Postfix) with SMTP id 8BAA96B02A9 for ; Sat, 23 Jun 2012 05:27:06 -0400 (EDT) Date: Sat, 23 Jun 2012 11:26:54 +0200 From: Johannes Weiner Subject: Re: [PATCH 1/6] memcg: replace unsigned long by u64 to avoid overflow Message-ID: <20120623092654.GL27816@cmpxchg.org> References: <1340432134-5178-1-git-send-email-liwp.linux@gmail.com> <20120623081514.GJ27816@cmpxchg.org> <20120623090339.GA6184@kernel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120623090339.GA6184@kernel> Sender: owner-linux-mm@kvack.org List-ID: To: Wanpeng Li Cc: linux-mm@kvack.org, Michal Hocko , Balbir Singh , KAMEZAWA Hiroyuki , Andrew Morton , Mel Gorman , Minchan Kim , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Gavin Shan On Sat, Jun 23, 2012 at 05:03:39PM +0800, Wanpeng Li wrote: > On Sat, Jun 23, 2012 at 10:15:14AM +0200, Johannes Weiner wrote: > >On Sat, Jun 23, 2012 at 02:15:34PM +0800, Wanpeng Li wrote: > >> From: Wanpeng Li > >> > >> Since the return value variable in mem_cgroup_zone_nr_lru_pages and > >> mem_cgroup_node_nr_lru_pages functions are u64, so replace the return > >> value of funtions by u64 to avoid overflow. > > > >I wonder what 16 TB of memory must think running on a 32-bit kernel... > >"What is this, an address space for ants?" > > Hi Johannes, > > You mean change all u64 in memcg to unsigned long? or something I > miss.... Not _all_ of them, we have some that count bytes. But those counting pages should probably be ulong, yes. I think Kame added the ones that you wanted to adjust the surroundings for in particular, so let's ask him. Kame? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org