From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx173.postini.com [74.125.245.173]) by kanga.kvack.org (Postfix) with SMTP id 511756B0069 for ; Wed, 20 Jun 2012 10:21:32 -0400 (EDT) Date: Wed, 20 Jun 2012 15:21:27 +0100 From: Mel Gorman Subject: Re: [PATCH 01/12] netvm: Prevent a stream-specific deadlock Message-ID: <20120620142127.GK4011@suse.de> References: <1340185081-22525-1-git-send-email-mgorman@suse.de> <1340185081-22525-2-git-send-email-mgorman@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1340185081-22525-2-git-send-email-mgorman@suse.de> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Linux-MM , Linux-Netdev , Linux-NFS , LKML , David Miller , Trond Myklebust , Neil Brown , Christoph Hellwig , Peter Zijlstra , Mike Christie , Eric B Munson On Wed, Jun 20, 2012 at 10:37:50AM +0100, Mel Gorman wrote: > It could happen that all !SOCK_MEMALLOC sockets have buffered so > much data that we're over the global rmem limit. This will prevent > SOCK_MEMALLOC buffers from receiving data, which will prevent userspace > from running, which is needed to reduce the buffered data. > > Fix this by exempting the SOCK_MEMALLOC sockets from the rmem limit. > Once this change it applied, it is important that sockets that set > SOCK_MEMALLOC do not clear the flag until the socket is being torn down. > If this happens, a warning is generated and the tokens reclaimed to > avoid accounting errors until the bug is fixed. > > [davem@davemloft.net: Warning about clearing SOCK_MEMALLOC] > Signed-off-by: Peter Zijlstra > Signed-off-by: Mel Gorman > Acked-by: David S. Miller This patch introduced a new warning that I had previously missed. I'll fix it up when rebasing this series on top of linux-next. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org