From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx198.postini.com [74.125.245.198]) by kanga.kvack.org (Postfix) with SMTP id 87B766B0062 for ; Wed, 20 Jun 2012 09:13:27 -0400 (EDT) Date: Wed, 20 Jun 2012 15:13:22 +0200 From: Michal Hocko Subject: Re: [PATCH v4 08/25] memcg: change defines to an enum Message-ID: <20120620131322.GD5541@tiehlicka.suse.cz> References: <1340015298-14133-1-git-send-email-glommer@parallels.com> <1340015298-14133-9-git-send-email-glommer@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1340015298-14133-9-git-send-email-glommer@parallels.com> Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: linux-mm@kvack.org, Pekka Enberg , Cristoph Lameter , David Rientjes , cgroups@vger.kernel.org, devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com, linux-kernel@vger.kernel.org, Frederic Weisbecker , Suleiman Souhlal , Johannes Weiner [Sorry for late reply. I am aware of the series, I am just too busy to give it serious time needed for review. It doesn't make much sense to delay these preparational pieces so...] On Mon 18-06-12 14:28:01, Glauber Costa wrote: > This is just a cleanup patch for clarity of expression. > In earlier submissions, people asked it to be in a separate > patch, so here it is. > > Signed-off-by: Glauber Costa > CC: Michal Hocko > CC: Johannes Weiner > Acked-by: Kamezawa Hiroyuki Acked-by: Michal Hocko > --- > mm/memcontrol.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index b6cb075..cc1fdb4 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -374,9 +374,12 @@ enum charge_type { > }; > > /* for encoding cft->private value on file */ > -#define _MEM (0) > -#define _MEMSWAP (1) > -#define _OOM_TYPE (2) > +enum res_type { > + _MEM, > + _MEMSWAP, > + _OOM_TYPE, > +}; > + > #define MEMFILE_PRIVATE(x, val) (((x) << 16) | (val)) > #define MEMFILE_TYPE(val) (((val) >> 16) & 0xffff) > #define MEMFILE_ATTR(val) ((val) & 0xffff) > -- > 1.7.10.2 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org