From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx108.postini.com [74.125.245.108]) by kanga.kvack.org (Postfix) with SMTP id A4E6E6B005C for ; Thu, 14 Jun 2012 03:38:02 -0400 (EDT) Date: Thu, 14 Jun 2012 09:38:00 +0200 From: Michal Hocko Subject: Re: [PATCH -V9 08/15] hugetlb: Make some static variables global Message-ID: <20120614073800.GF27397@tiehlicka.suse.cz> References: <1339583254-895-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1339583254-895-9-git-send-email-aneesh.kumar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1339583254-895-9-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com, dhillf@gmail.com, rientjes@google.com, akpm@linux-foundation.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org On Wed 13-06-12 15:57:27, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > We will use them later in hugetlb_cgroup.c > > Signed-off-by: Aneesh Kumar K.V Reviewed-by: Michal Hocko Just a nit [...] > +extern int hugetlb_max_hstate; Maybe we can mark it __read_mostly as it is modified only during initialization and then it is just a constant. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org