From: Michal Hocko <mhocko@suse.cz>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com,
dhillf@gmail.com, rientjes@google.com, akpm@linux-foundation.org,
hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH -V8 10/16] hugetlb/cgroup: Add the cgroup pointer to page lru
Date: Mon, 11 Jun 2012 11:16:58 +0200 [thread overview]
Message-ID: <20120611091658.GG12402@tiehlicka.suse.cz> (raw)
In-Reply-To: <87oboq5ifb.fsf@skywalker.in.ibm.com>
On Mon 11-06-12 14:33:52, Aneesh Kumar K.V wrote:
> Michal Hocko <mhocko@suse.cz> writes:
>
> > On Sat 09-06-12 14:29:55, Aneesh Kumar K.V wrote:
> >> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
> >>
> >> Add the hugetlb cgroup pointer to 3rd page lru.next.
> >
> > Interesting and I really like the idea much more than tracking by
> > page_cgroup.
> >
> >> This limit the usage to hugetlb cgroup to only hugepages with 3 or
> >> more normal pages. I guess that is an acceptable limitation.
> >
> > Agreed.
> >
> >> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> >
> > Other than some nits I like this.
> > Thanks!
> >
> >> ---
> >> include/linux/hugetlb_cgroup.h | 31 +++++++++++++++++++++++++++++++
> >> mm/hugetlb.c | 4 ++++
> >> 2 files changed, 35 insertions(+)
> >>
> >> diff --git a/include/linux/hugetlb_cgroup.h b/include/linux/hugetlb_cgroup.h
> >> index 5794be4..ceff1d5 100644
> >> --- a/include/linux/hugetlb_cgroup.h
> >> +++ b/include/linux/hugetlb_cgroup.h
> >> @@ -26,6 +26,26 @@ struct hugetlb_cgroup {
> >> };
> >>
> >> #ifdef CONFIG_CGROUP_HUGETLB_RES_CTLR
> >> +static inline struct hugetlb_cgroup *hugetlb_cgroup_from_page(struct page *page)
> >> +{
> >> + if (!PageHuge(page))
> >> + return NULL;
> >> + if (compound_order(page) < 3)
> >
> > Why 3? I think you wanted 2 here, right?
>
> Yes that should be 2. I updated that in an earlier. Already in v9
> version I have locally.
ohh, I should have read replies to the patch first where you already
mentioned that you are aware of that.
Maybe it would be worth something like:
/* Minimum page order trackable by hugetlb cgroup.
* At least 3 pages are necessary for all the tracking information.
*/
#define HUGETLB_CGROUP_MIN_ORDER 2
> >> @@ -591,6 +592,7 @@ static void update_and_free_page(struct hstate *h, struct page *page)
> >> 1 << PG_active | 1 << PG_reserved |
> >> 1 << PG_private | 1 << PG_writeback);
> >> }
> >> + BUG_ON(hugetlb_cgroup_from_page(page));
> >
> > What about VM_BUG_ON?
>
> Will do, So when do one decide to choose VM_BUG_ON against BUG_ON ?
I think that VM_ variant is more approapriate here because it is more a
debugging thing rather than a hard failure invariant.
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-11 9:17 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 8:59 [PATCH -V8 00/16] hugetlb: Add HugeTLB controller to control HugeTLB allocation Aneesh Kumar K.V
2012-06-09 8:59 ` [PATCH -V8 01/16] hugetlb: rename max_hstate to hugetlb_max_hstate Aneesh Kumar K.V
2012-06-09 8:59 ` [PATCH -V8 02/16] hugetlb: don't use ERR_PTR with VM_FAULT* values Aneesh Kumar K.V
2012-06-09 11:10 ` Konrad Rzeszutek Wilk
2012-06-09 13:17 ` Aneesh Kumar K.V
2012-06-09 19:28 ` KOSAKI Motohiro
2012-06-10 1:59 ` Hillf Danton
2012-06-09 8:59 ` [PATCH -V8 03/16] hugetlb: add an inline helper for finding hstate index Aneesh Kumar K.V
2012-06-09 8:59 ` [PATCH -V8 04/16] hugetlb: use mmu_gather instead of a temporary linked list for accumulating pages Aneesh Kumar K.V
2012-06-09 8:59 ` [PATCH -V8 05/16] hugetlb: avoid taking i_mmap_mutex in unmap_single_vma() for hugetlb Aneesh Kumar K.V
2012-06-09 9:44 ` Johannes Weiner
2012-06-09 13:03 ` Aneesh Kumar K.V
2012-06-09 14:49 ` Johannes Weiner
2012-06-09 8:59 ` [PATCH -V8 06/16] hugetlb: simplify migrate_huge_page() Aneesh Kumar K.V
2012-06-12 7:31 ` Kamezawa Hiroyuki
2012-06-09 8:59 ` [PATCH -V8 07/16] hugetlb: add a list for tracking in-use HugeTLB pages Aneesh Kumar K.V
2012-06-09 8:59 ` [PATCH -V8 08/16] hugetlb: Make some static variables global Aneesh Kumar K.V
2012-06-12 7:35 ` Kamezawa Hiroyuki
2012-06-09 8:59 ` [PATCH -V8 09/16] mm/hugetlb: Add new HugeTLB cgroup Aneesh Kumar K.V
2012-06-12 7:46 ` Kamezawa Hiroyuki
2012-06-12 9:37 ` Aneesh Kumar K.V
2012-06-09 8:59 ` [PATCH -V8 10/16] hugetlb/cgroup: Add the cgroup pointer to page lru Aneesh Kumar K.V
2012-06-09 11:14 ` Konrad Rzeszutek Wilk
2012-06-09 17:04 ` Aneesh Kumar K.V
2012-06-11 8:16 ` Michal Hocko
2012-06-11 9:03 ` Aneesh Kumar K.V
2012-06-11 9:16 ` Michal Hocko [this message]
2012-06-11 9:33 ` Aneesh Kumar K.V
2012-06-11 8:41 ` Kamezawa Hiroyuki
2012-06-12 7:52 ` Kamezawa Hiroyuki
2012-06-12 9:40 ` Aneesh Kumar K.V
2012-06-09 8:59 ` [PATCH -V8 11/16] hugetlb/cgroup: Add charge/uncharge routines for hugetlb cgroup Aneesh Kumar K.V
2012-06-11 8:38 ` Michal Hocko
2012-06-11 9:10 ` Michal Hocko
2012-06-11 9:28 ` Aneesh Kumar K.V
2012-06-11 12:59 ` Michal Hocko
2012-06-11 15:35 ` Aneesh Kumar K.V
2012-06-12 8:08 ` Kamezawa Hiroyuki
2012-06-12 10:50 ` Aneesh Kumar K.V
2012-06-13 11:02 ` Kamezawa Hiroyuki
2012-06-09 8:59 ` [PATCH -V8 12/16] hugetlb/cgroup: Add support for cgroup removal Aneesh Kumar K.V
2012-06-11 8:52 ` Michal Hocko
2012-06-11 9:40 ` Aneesh Kumar K.V
2012-06-11 13:14 ` Michal Hocko
2012-06-11 15:34 ` Aneesh Kumar K.V
2012-06-12 8:23 ` Kamezawa Hiroyuki
2012-06-12 10:52 ` Aneesh Kumar K.V
2012-06-09 8:59 ` [PATCH -V8 13/16] hugetlb/cgroup: add hugetlb cgroup control files Aneesh Kumar K.V
2012-06-09 11:19 ` Konrad Rzeszutek Wilk
2012-06-11 9:02 ` Michal Hocko
2012-06-11 9:43 ` Aneesh Kumar K.V
2012-06-11 13:15 ` Michal Hocko
2012-06-12 8:35 ` Kamezawa Hiroyuki
2012-06-12 10:58 ` Aneesh Kumar K.V
2012-06-13 0:16 ` Kamezawa Hiroyuki
2012-06-09 8:59 ` [PATCH -V8 14/16] hugetlb/cgroup: add charge/uncharge calls for HugeTLB alloc/free Aneesh Kumar K.V
2012-06-09 9:23 ` Johannes Weiner
2012-06-09 13:09 ` Aneesh Kumar K.V
2012-06-09 14:30 ` Johannes Weiner
2012-06-09 15:55 ` Aneesh Kumar K.V
2012-06-11 9:19 ` Michal Hocko
2012-06-11 9:21 ` Michal Hocko
2012-06-11 10:29 ` Aneesh Kumar K.V
2012-06-09 9:00 ` [PATCH -V8 15/16] hugetlb/cgroup: migrate hugetlb cgroup info from oldpage to new page during migration Aneesh Kumar K.V
2012-06-11 9:24 ` Michal Hocko
2012-06-11 10:17 ` Aneesh Kumar K.V
2012-06-12 8:51 ` Kamezawa Hiroyuki
2012-06-12 11:00 ` Aneesh Kumar K.V
2012-06-13 11:15 ` Kamezawa Hiroyuki
2012-06-09 9:00 ` [PATCH -V8 16/16] hugetlb/cgroup: add HugeTLB controller documentation Aneesh Kumar K.V
2012-06-12 8:57 ` Kamezawa Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611091658.GG12402@tiehlicka.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cgroups@vger.kernel.org \
--cc=dhillf@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox