From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx131.postini.com [74.125.245.131]) by kanga.kvack.org (Postfix) with SMTP id 56B3C6B00DC for ; Mon, 11 Jun 2012 05:10:24 -0400 (EDT) Date: Mon, 11 Jun 2012 11:10:21 +0200 From: Michal Hocko Subject: Re: [PATCH -V8 11/16] hugetlb/cgroup: Add charge/uncharge routines for hugetlb cgroup Message-ID: <20120611091021.GF12402@tiehlicka.suse.cz> References: <1339232401-14392-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1339232401-14392-12-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20120611083810.GC12402@tiehlicka.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120611083810.GC12402@tiehlicka.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com, dhillf@gmail.com, rientjes@google.com, akpm@linux-foundation.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org On Mon 11-06-12 10:38:10, Michal Hocko wrote: > On Sat 09-06-12 14:29:56, Aneesh Kumar K.V wrote: > > From: "Aneesh Kumar K.V" > > > > This patchset add the charge and uncharge routines for hugetlb cgroup. > > This will be used in later patches when we allocate/free HugeTLB > > pages. > > Please describe the locking rules. > > > Signed-off-by: Aneesh Kumar K.V > > --- > > mm/hugetlb_cgroup.c | 87 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 87 insertions(+) > > > > diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c > > index 20a32c5..48efd5a 100644 > > --- a/mm/hugetlb_cgroup.c > > +++ b/mm/hugetlb_cgroup.c > > @@ -105,6 +105,93 @@ static int hugetlb_cgroup_pre_destroy(struct cgroup *cgroup) > > return -EBUSY; > > } > > > > +int hugetlb_cgroup_charge_page(int idx, unsigned long nr_pages, > > + struct hugetlb_cgroup **ptr) > > Missing doc. And now that I am looking at the patch which uses this function then I realized that the name shouldn't mention page as we do not use any as an argument. It is more in lines with hugetlb_cgroup_charge_cgroup -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org