From: Simon Baatz <gmbnomis@gmail.com>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Stephane Marchesin <marcheu@chromium.org>,
Andi Kleen <andi@firstfloor.org>, Dave Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, Rob Clark <rob.clark@linaro.org>,
Cong Wang <xiyou.wangcong@gmail.com>,
linux-mm@kvack.org, linux-fsdevel@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] shmem: replace_page must flush_dcache and others
Date: Fri, 8 Jun 2012 10:40:33 +0200 [thread overview]
Message-ID: <20120608084033.GA21818@schnuecks.de> (raw)
In-Reply-To: <alpine.LSU.2.00.1205311524160.4512@eggly.anvils>
Hi Hugh,
On Thu, May 31, 2012 at 03:31:27PM -0700, Hugh Dickins wrote:
> * shmem_replace_page must flush_dcache_page after copy_highpage [akpm]
>
> - *pagep = newpage;
> page_cache_get(newpage);
> copy_highpage(newpage, oldpage);
> + flush_dcache_page(newpage);
>
Couldn't we use the lighter flush_kernel_dcache_page() here (like in
fs/exec.c copy_strings())? If I got this correctly, the page is
copied via the kernel mapping and thus, only the kernel mapping needs
to be flushed.
- Simon
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-08 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 22:31 Hugh Dickins
2012-06-08 8:40 ` Simon Baatz [this message]
2012-06-14 8:20 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120608084033.GA21818@schnuecks.de \
--to=gmbnomis@gmail.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=daniel@ffwll.ch \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-fsdevel@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcheu@chromium.org \
--cc=rob.clark@linaro.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox