From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx144.postini.com [74.125.245.144]) by kanga.kvack.org (Postfix) with SMTP id 890F66B005C for ; Mon, 4 Jun 2012 06:01:49 -0400 (EDT) Received: from euspt1 (mailout2.w1.samsung.com [210.118.77.12]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M5300KCN7VV0580@mailout2.w1.samsung.com> for linux-mm@kvack.org; Mon, 04 Jun 2012 11:02:19 +0100 (BST) Received: from linux.samsung.com ([106.116.38.10]) by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0M53002UC7UZ4M@spt1.w1.samsung.com> for linux-mm@kvack.org; Mon, 04 Jun 2012 11:01:47 +0100 (BST) Date: Mon, 04 Jun 2012 12:01:20 +0200 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 2/2] proc: add ARCH_PFN_OFFSET info to /proc/meminfo In-reply-to: <4FCC835C.3010007@gmail.com> Message-id: <201206041201.20939.b.zolnierkie@samsung.com> MIME-version: 1.0 Content-type: Text/Plain; charset=iso-8859-1 Content-transfer-encoding: 7BIT References: <201206011854.17399.b.zolnierkie@samsung.com> <201206041018.13568.b.zolnierkie@samsung.com> <4FCC835C.3010007@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: KOSAKI Motohiro Cc: linux-mm@kvack.org, Kyungmin Park , Matt Mackall On Monday 04 June 2012 11:43:56 KOSAKI Motohiro wrote: > (6/4/12 4:18 AM), Bartlomiej Zolnierkiewicz wrote: > > On Friday 01 June 2012 22:26:57 KOSAKI Motohiro wrote: > >> (6/1/12 12:54 PM), Bartlomiej Zolnierkiewicz wrote: > >>> From: Bartlomiej Zolnierkiewicz > >>> Subject: [PATCH] proc: add ARCH_PFN_OFFSET info to /proc/meminfo > >>> > >>> ARCH_PFN_OFFSET is needed for user-space to use together with > >>> /proc/kpage[count,flags] interfaces. > >>> > >>> Cc: Matt Mackall > >>> Signed-off-by: Bartlomiej Zolnierkiewicz > >>> Signed-off-by: Kyungmin Park > >>> --- > >>> fs/proc/meminfo.c | 4 ++++ > >>> 1 file changed, 4 insertions(+) > >>> > >>> Index: b/fs/proc/meminfo.c > >>> =================================================================== > >>> --- a/fs/proc/meminfo.c 2012-05-31 16:53:11.589706973 +0200 > >>> +++ b/fs/proc/meminfo.c 2012-05-31 17:03:17.719237120 +0200 > >>> @@ -168,6 +168,10 @@ static int meminfo_proc_show(struct seq_ > >>> > >>> hugetlb_report_meminfo(m); > >>> > >>> + seq_printf(m, > >>> + "ArchPFNOffset: %6lu\n", > >>> + ARCH_PFN_OFFSET); > >>> + > >>> arch_report_meminfo(m); > >> > >> NAK. > >> > >> arch specific report should use arch_report_meminfo(). > > > > ARCH_PFN_OFFSET is defined for all archs so I think that it makes little > > sense to duplicate it in every per-arch arch_report_meminfo().. > > Incorrect. We are usually constant value for ARCH_PFN_OFFSET. so we don't need > any exporting. Have you seen patch #1/2 ("PATCH] proc: fix kpage[count,flags] interfaces to account for ARCH_PFN_OFFSET")? We need to export ARCH_PFN_OFFSET to user-space to use /proc/kpage[count,flags] an archs that make use of ARCH_PFN_OFFSET. Best regards, -- Bartlomiej Zolnierkiewicz Samsung Poland R&D Center -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org