Re: [PATCH 2/2] proc: add ARCH_PFN_OFFSET info to /proc/meminfo

[Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>]

On Monday 04 June 2012 11:43:56 KOSAKI Motohiro wrote:
> (6/4/12 4:18 AM), Bartlomiej Zolnierkiewicz wrote:
> > On Friday 01 June 2012 22:26:57 KOSAKI Motohiro wrote:
> >> (6/1/12 12:54 PM), Bartlomiej Zolnierkiewicz wrote:
> >>> From: Bartlomiej Zolnierkiewicz<b.zolnierkie@samsung.com>
> >>> Subject: [PATCH] proc: add ARCH_PFN_OFFSET info to /proc/meminfo
> >>>
> >>> ARCH_PFN_OFFSET is needed for user-space to use together with
> >>> /proc/kpage[count,flags] interfaces.
> >>>
> >>> Cc: Matt Mackall<mpm@selenic.com>
> >>> Signed-off-by: Bartlomiej Zolnierkiewicz<b.zolnierkie@samsung.com>
> >>> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
> >>> ---
> >>>    fs/proc/meminfo.c |    4 ++++
> >>>    1 file changed, 4 insertions(+)
> >>>
> >>> Index: b/fs/proc/meminfo.c
> >>> ===================================================================
> >>> --- a/fs/proc/meminfo.c	2012-05-31 16:53:11.589706973 +0200
> >>> +++ b/fs/proc/meminfo.c	2012-05-31 17:03:17.719237120 +0200
> >>> @@ -168,6 +168,10 @@ static int meminfo_proc_show(struct seq_
> >>>
> >>>    	hugetlb_report_meminfo(m);
> >>>
> >>> +	seq_printf(m,
> >>> +		"ArchPFNOffset:    %6lu\n",
> >>> +		ARCH_PFN_OFFSET);
> >>> +
> >>>    	arch_report_meminfo(m);
> >>
> >> NAK.
> >>
> >> arch specific report should use arch_report_meminfo().
> >
> > ARCH_PFN_OFFSET is defined for all archs so I think that it makes little
> > sense to duplicate it in every per-arch arch_report_meminfo()..
> 
> Incorrect. We are usually constant value for ARCH_PFN_OFFSET. so we don't need
> any exporting.

Have you seen patch #1/2 ("PATCH] proc: fix kpage[count,flags] interfaces to
account for ARCH_PFN_OFFSET")?

We need to export ARCH_PFN_OFFSET to user-space to use /proc/kpage[count,flags]
an archs that make use of ARCH_PFN_OFFSET.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung Poland R&D Center

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>