From: Jan Kara <jack@suse.cz>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Jan Kara <jack@suse.cz>, Sasha Levin <levinsasha928@gmail.com>,
Wu Fengguang <fengguang.wu@intel.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] block: Convert BDI proportion calculations to flexible proportions
Date: Tue, 29 May 2012 14:54:52 +0200 [thread overview]
Message-ID: <20120529125452.GB23991@quack.suse.cz> (raw)
In-Reply-To: <1338295111.26856.57.camel@twins>
On Tue 29-05-12 14:38:31, Peter Zijlstra wrote:
> On Tue, 2012-05-29 at 14:34 +0200, Jan Kara wrote:
>
> > The only safe solution seems to be to create a variant of percpu counters
> > that can be used from an interrupt. Or do you have other idea Peter?
>
> > > [ 20.680186] [<ffffffff8325ac9b>] _raw_spin_lock+0x3b/0x70
> > > [ 20.680186] [<ffffffff81993527>] ? __percpu_counter_sum+0x17/0xc0
> > > [ 20.680186] [<ffffffff81993527>] __percpu_counter_sum+0x17/0xc0
> > > [ 20.680186] [<ffffffff810ebf90>] ? init_timer_deferrable_key+0x20/0x20
> > > [ 20.680186] [<ffffffff8195b5c2>] fprop_new_period+0x12/0x60
> > > [ 20.680186] [<ffffffff811d929d>] writeout_period+0x3d/0xa0
> > > [ 20.680186] [<ffffffff810ec0bf>] call_timer_fn+0x12f/0x260
> > > [ 20.680186] [<ffffffff810ebf90>] ? init_timer_deferrable_key+0x20/0x20
>
> Yeah, just make sure IRQs are disabled around doing that ;-)
Evil ;) But we'd need to have IRQs disabled also in each
fprop_fraction_percpu() call, and generally, if we want things clean, we'd
need to disable them in all entry points to proportion code (or at least
around all percpu calls)...
Honza
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-29 12:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 16:59 [PATCH 0/2 v4] Flexible proportions Jan Kara
2012-05-24 16:59 ` [PATCH 1/2] lib: Proportions with flexible period Jan Kara
2012-05-24 16:59 ` [PATCH 2/2] block: Convert BDI proportion calculations to flexible proportions Jan Kara
2012-05-28 15:49 ` Sasha Levin
2012-05-29 12:34 ` Jan Kara
2012-05-29 12:38 ` Peter Zijlstra
2012-05-29 12:54 ` Jan Kara [this message]
2012-05-31 22:11 ` Jan Kara
2012-05-31 22:26 ` Peter Zijlstra
2012-05-31 22:42 ` Jan Kara
2012-06-01 3:10 ` Fengguang Wu
2012-06-01 10:13 ` Peter Zijlstra
2012-05-25 9:12 ` [PATCH 0/2 v4] Flexible proportions Peter Zijlstra
2012-05-25 9:29 ` Fengguang Wu
-- strict thread matches above, loose matches on Subject: below --
2012-05-15 15:43 [PATCH 0/2 v3] " Jan Kara
2012-05-15 15:43 ` [PATCH 2/2] block: Convert BDI proportion calculations to flexible proportions Jan Kara
2012-05-17 22:04 ` Peter Zijlstra
2012-05-18 14:24 ` Jan Kara
2012-05-18 14:34 ` Peter Zijlstra
2012-05-03 22:39 [PATCH 0/2 v2] Flexible proportions for BDIs Jan Kara
2012-05-03 22:39 ` [PATCH 2/2] block: Convert BDI proportion calculations to flexible proportions Jan Kara
2012-05-07 14:47 ` Fengguang Wu
2012-05-07 15:21 ` Peter Zijlstra
2012-05-09 11:38 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120529125452.GB23991@quack.suse.cz \
--to=jack@suse.cz \
--cc=fengguang.wu@intel.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox