From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx182.postini.com [74.125.245.182]) by kanga.kvack.org (Postfix) with SMTP id DCEE26B0083 for ; Tue, 22 May 2012 17:28:37 -0400 (EDT) Date: Tue, 22 May 2012 14:28:35 -0700 From: Andrew Morton Subject: Re: [PATCH] hugetlb: fix resv_map leak in error path Message-Id: <20120522142835.50b86ddc.akpm@linux-foundation.org> In-Reply-To: References: <20120521202814.E01F0FE1@kernel> <20120522134558.49255899.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: Dave Hansen , linux-kernel@vger.kernel.org, linux-mm@kvack.org, aarcange@redhat.com, kosaki.motohiro@jp.fujitsu.com, hughd@google.com, rientjes@google.com, adobriyan@gmail.com, mel@csn.ul.ie, stable@vger.kernel.org On Tue, 22 May 2012 16:05:02 -0500 (CDT) Christoph Lameter wrote: > > How far back does this bug go? The patch applies to 3.4 but gets > > rejects in 3.3 and earlier. > > The earliest that I have seen it on was 2.6.32. I have rediffed the patch > against 2.6.32 and 3.2.0. Great, thanks. I did : From: Dave Hansen : Subject: hugetlb: fix resv_map leak in error path : : When called for anonymous (non-shared) mappings, hugetlb_reserve_pages() : does a resv_map_alloc(). It depends on code in hugetlbfs's : vm_ops->close() to release that allocation. : : However, in the mmap() failure path, we do a plain unmap_region() without : the remove_vma() which actually calls vm_ops->close(). : : This is a decent fix. This leak could get reintroduced if new code (say, : after hugetlb_reserve_pages() in hugetlbfs_file_mmap()) decides to return : an error. But, I think it would have to unroll the reservation anyway. : : Christoph's test case: : : http://marc.info/?l=linux-mm&m=133728900729735 : : This patch applies to 3.4 and later. A version for earlier kernels is at : https://lkml.org/lkml/2012/5/22/418. : : Signed-off-by: Dave Hansen : Acked-by: Mel Gorman : Acked-by: KOSAKI Motohiro : Reported-by: Christoph Lameter : Tested-by: Christoph Lameter : Cc: Andrea Arcangeli : Cc: [2.6.32+] -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org