From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx173.postini.com [74.125.245.173]) by kanga.kvack.org (Postfix) with SMTP id D8F096B00EA for ; Wed, 16 May 2012 10:50:38 -0400 (EDT) Received: by pbbrp2 with SMTP id rp2so1755432pbb.14 for ; Wed, 16 May 2012 07:50:38 -0700 (PDT) Date: Wed, 16 May 2012 07:50:32 -0700 From: Greg Kroah-Hartman Subject: Re: [PATCH] slub: fix a memory leak in get_partial_node() Message-ID: <20120516145032.GA1139@kroah.com> References: <1337108498-4104-1-git-send-email-js1304@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: JoonSoo Kim Cc: Pekka Enberg , Christoph Lameter , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org On Wed, May 16, 2012 at 10:56:50PM +0900, JoonSoo Kim wrote: > 2012/5/16 Pekka Enberg : > > > > >> On Wed, 16 May 2012, Joonsoo Kim wrote: > >> > >> > In the case which is below, > >> > > >> > 1. acquire slab for cpu partial list > >> > 2. free object to it by remote cpu > >> > 3. page->freelist = t > >> > > >> > then memory leak is occurred. > >> > >> Hmmm... Ok so we cannot assign page->freelist in get_partial_node() for > >> the cpu partial slabs. It must be done in the cmpxchg transition. > >> > >> Acked-by: Christoph Lameter > > > > Joonsoo, can you please fix up the stable submission format, add > > Christoph's ACK and resend? > > > > Pekka > > Thanks for comment. > I'm a kernel newbie, > so could you please tell me how to fix up the stable submission format? > I'm eager to fix it up, but I don't know how to. > > I read stable_kernel_rules.txt, this article tells me I must note > upstream commit ID. > Above patch is not included in upstream currently, so I can't find > upstream commit ID. > Is 'Acked-by from MAINTAINER' sufficient for submitting to stable-kernel? > Is below format right for stable submission format? No. Please read the second item in the list that says: "Procedure for submitting patches to the -stable tree" in the file, Documentation/stable_kernel_rulest.txt. It states: - To have the patch automatically included in the stable tree, add the tag Cc: stable@vger.kernel.org in the sign-off area. Once the patch is merged it will be applied to the stable tree without anything else needing to be done by the author or subsystem maintainer. Does that help? thanks, greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org