From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx124.postini.com [74.125.245.124]) by kanga.kvack.org (Postfix) with SMTP id ABF326B004A for ; Fri, 27 Apr 2012 04:10:25 -0400 (EDT) Date: Fri, 27 Apr 2012 10:10:21 +0200 From: Michal Hocko Subject: Re: [patch 2/2] mm: memcg: count pte references from every member of the reclaimed hierarchy Message-ID: <20120427081021.GA6969@tiehlicka.suse.cz> References: <1335296144-29381-1-git-send-email-hannes@cmpxchg.org> <1335296144-29381-2-git-send-email-hannes@cmpxchg.org> <20120426143729.10f672ae.akpm@linux-foundation.org> <20120426234819.GB1788@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120426234819.GB1788@cmpxchg.org> Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: Andrew Morton , Konstantin Khlebnikov , KAMEZAWA Hiroyuki , Li Zefan , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org On Fri 27-04-12 01:48:19, Johannes Weiner wrote: [...] > From: Johannes Weiner > Subject: [patch] mm: memcg: clean up mm_match_cgroup() signature > > It really should return a boolean for match/no match. And since it > takes a memcg, not a cgroup, fix that parameter name as well. > > Signed-off-by: Johannes Weiner Acked-by: Michal Hocko > --- > include/linux/memcontrol.h | 14 +++++++------- > 1 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 76f9d9b..d3038a9 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -89,14 +89,14 @@ extern struct mem_cgroup *parent_mem_cgroup(struct mem_cgroup *memcg); > extern struct mem_cgroup *mem_cgroup_from_cont(struct cgroup *cont); > > static inline > -int mm_match_cgroup(const struct mm_struct *mm, const struct mem_cgroup *cgroup) > +bool mm_match_cgroup(const struct mm_struct *mm, const struct mem_cgroup *memcg) > { > - struct mem_cgroup *memcg; > - int match; > + struct mem_cgroup *task_memcg; > + bool match; > > rcu_read_lock(); > - memcg = mem_cgroup_from_task(rcu_dereference((mm)->owner)); > - match = memcg && __mem_cgroup_same_or_subtree(cgroup, memcg); > + task_memcg = mem_cgroup_from_task(rcu_dereference((mm)->owner)); > + match = task_memcg && __mem_cgroup_same_or_subtree(memcg, task_memcg); > rcu_read_unlock(); > return match; > } > @@ -281,10 +281,10 @@ static inline struct mem_cgroup *try_get_mem_cgroup_from_mm(struct mm_struct *mm > return NULL; > } > > -static inline int mm_match_cgroup(struct mm_struct *mm, > +static inline bool mm_match_cgroup(struct mm_struct *mm, > struct mem_cgroup *memcg) > { > - return 1; > + return true; > } > > static inline int task_in_mem_cgroup(struct task_struct *task, > -- > 1.7.7.6 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ > Don't email: email@kvack.org -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org