linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	linux-mm@kvack.org
Subject: Re: [patch] mm, thp: drop page_table_lock to uncharge memcg pages
Date: Fri, 27 Apr 2012 01:57:00 +0200	[thread overview]
Message-ID: <20120426235700.GC1788@cmpxchg.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1204261556100.15785@chino.kir.corp.google.com>

On Thu, Apr 26, 2012 at 03:57:30PM -0700, David Rientjes wrote:
> mm->page_table_lock is hotly contested for page fault tests and isn't
> necessary to do mem_cgroup_uncharge_page() in do_huge_pmd_wp_page().
> 
> Signed-off-by: David Rientjes <rientjes@google.com>

Probably rare, but since it's just two lines and the uncharge path
really does a ridiculous amount of things, I'm happy with moving it
out of the locked section.

Acked-by: Johannes Weiner <hannes@cmpxchg.org>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      parent reply	other threads:[~2012-04-26 23:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-26 22:57 David Rientjes
2012-04-26 23:39 ` Andrew Morton
2012-04-26 23:44   ` David Rientjes
2012-04-27 19:00     ` Andrea Arcangeli
2012-04-26 23:57 ` Johannes Weiner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120426235700.GC1788@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox