From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx150.postini.com [74.125.245.150]) by kanga.kvack.org (Postfix) with SMTP id 6EA7D6B0044 for ; Mon, 23 Apr 2012 22:14:38 -0400 (EDT) Date: Mon, 23 Apr 2012 22:09:19 -0400 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency Message-ID: <20120424020919.GA18972@phenom.dumpdata.com> References: <1335231230-29344-1-git-send-email-sjenning@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1335231230-29344-1-git-send-email-sjenning@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Seth Jennings Cc: Greg Kroah-Hartman , Dan Magenheimer , Nitin Gupta , Robert Jennings , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Autif Khan On Mon, Apr 23, 2012 at 08:33:50PM -0500, Seth Jennings wrote: > ZCACHE is a boolean in the Kconfig. When selected, it > should require that CRYPTO be builtin (=y). Hey Greg, Please push this to your tree at your convience. linux-next folks found this combination breaks the build .. > > Currently, ZCACHE=y and CRYPTO=m is a valid configuration > when it should not be. > > This patch changes the zcache Kconfig to enforce this > dependency. > > Signed-off-by: Seth Jennings Acked-by: Konrad Rzeszutek Wilk > --- > drivers/staging/zcache/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig > index 3ed2c8f..7048e01 100644 > --- a/drivers/staging/zcache/Kconfig > +++ b/drivers/staging/zcache/Kconfig > @@ -2,7 +2,7 @@ config ZCACHE > bool "Dynamic compression of swap pages and clean pagecache pages" > # X86 dependency is because zsmalloc uses non-portable pte/tlb > # functions > - depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86 > + depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86 > select ZSMALLOC > select CRYPTO_LZO > default n > -- > 1.7.5.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org