linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Ying Han <yinghan@google.com>
Cc: Michal Hocko <mhocko@suse.cz>, Mel Gorman <mel@csn.ul.ie>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Rik van Riel <riel@redhat.com>, Hillf Danton <dhillf@gmail.com>,
	Hugh Dickins <hughd@google.com>,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	linux-mm@kvack.org
Subject: Re: [PATCH V2 1/5] memcg: revert current soft limit reclaim implementation
Date: Thu, 12 Apr 2012 02:04:13 +0200	[thread overview]
Message-ID: <20120412000413.GB1787@cmpxchg.org> (raw)
In-Reply-To: <1334181594-26671-1-git-send-email-yinghan@google.com>

On Wed, Apr 11, 2012 at 02:59:54PM -0700, Ying Han wrote:
> This patch reverts all the existing softlimit reclaim implementations.

This ordering makes it quite hard to revert individual patches after
merging in case they are faulty, because we end up with a tree state
that has no soft limit implementation at all, or a newly broken one.

Could you reorder the series such that each patch leaves the tree in a
sane state?

I.e. also don't introduce an endless loop in the page allocator
through one patch and fix it later in another one ;) Noone will be
able to remember these cross-dependencies in a couple of weeks.

Thanks!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-04-12  0:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 21:59 Ying Han
2012-04-12  0:04 ` Johannes Weiner [this message]
2012-04-16 17:28   ` Ying Han
2012-04-14 12:41 ` Hillf Danton
2012-04-16 17:33   ` Ying Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120412000413.GB1787@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=dan.magenheimer@oracle.com \
    --cc=dhillf@gmail.com \
    --cc=hughd@google.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=mhocko@suse.cz \
    --cc=riel@redhat.com \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox