From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx129.postini.com [74.125.245.129]) by kanga.kvack.org (Postfix) with SMTP id D2F746B00F2 for ; Tue, 10 Apr 2012 07:47:34 -0400 (EDT) From: Arnd Bergmann Subject: Re: [PATCHv8 05/10] ARM: dma-mapping: use asm-generic/dma-mapping-common.h Date: Tue, 10 Apr 2012 11:47:20 +0000 References: <1334055852-19500-1-git-send-email-m.szyprowski@samsung.com> <1334055852-19500-6-git-send-email-m.szyprowski@samsung.com> In-Reply-To: <1334055852-19500-6-git-send-email-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201204101147.20733.arnd@arndb.de> Sender: owner-linux-mm@kvack.org List-ID: To: Marek Szyprowski Cc: linux-arm-kernel@lists.infradead.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, iommu@lists.linux-foundation.org, Kyungmin Park , Joerg Roedel , Russell King - ARM Linux , Chunsang Jeong , Krishna Reddy , KyongHo Cho , Andrzej Pietrasiewicz , Benjamin Herrenschmidt , Konrad Rzeszutek Wilk , Hiroshi Doyu , Subash Patel On Tuesday 10 April 2012, Marek Szyprowski wrote: > This patch modifies dma-mapping implementation on ARM architecture to > use common dma_map_ops structure and asm-generic/dma-mapping-common.h > helpers. > > Signed-off-by: Marek Szyprowski > Acked-by: Kyungmin Park > --- > arch/arm/Kconfig | 1 + > arch/arm/include/asm/device.h | 1 + > arch/arm/include/asm/dma-mapping.h | 196 +++++------------------------------- > arch/arm/mm/dma-mapping.c | 148 ++++++++++++++++----------- > 4 files changed, 115 insertions(+), 231 deletions(-) Looks good in principle. One question: Now that many of the functions are only used in the dma_map_ops, can you make them 'static' instead? Arnd -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org