From: Michal Hocko <mhocko@suse.cz>
To: David Rientjes <rientjes@google.com>
Cc: Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org
Subject: Re: [patch] memcg swap: use mem_cgroup_uncharge_swap fix
Date: Thu, 5 Apr 2012 07:49:50 -0700 [thread overview]
Message-ID: <20120405144949.GA17770@tiehlicka.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.00.1204042017520.8789@chino.kir.corp.google.com>
On Wed 04-04-12 20:19:18, David Rientjes wrote:
> linux-next fails with this
>
> mm/memcontrol.c: In function '__mem_cgroup_commit_charge_swapin':
> mm/memcontrol.c:2837: error: implicit declaration of function 'mem_cgroup_uncharge_swap'
>
> if CONFIG_SWAP is disabled. Fix it.
Although this is correct maybe it would be better to move the definition
outside the CONFIG_SWAP to prevent from duplication
What do you think about the following?
---
prev parent reply other threads:[~2012-04-05 14:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 20:54 [PATCH] memcg swap: use mem_cgroup_uncharge_swap Hugh Dickins
2012-03-24 0:29 ` Johannes Weiner
2012-03-26 1:13 ` KAMEZAWA Hiroyuki
2012-04-05 3:19 ` [patch] memcg swap: use mem_cgroup_uncharge_swap fix David Rientjes
2012-04-05 14:49 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120405144949.GA17770@tiehlicka.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox