From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Hugh Dickins <hughd@google.com>,
Johannes Weiner <jweiner@redhat.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4.5/7] mm: optimize isolate_lru_pages()
Date: Tue, 13 Mar 2012 14:26:35 +0900 [thread overview]
Message-ID: <20120313142635.a6a7b806.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20120311141334.29756.79407.stgit@zurg>
On Sun, 11 Mar 2012 18:36:16 +0400
Konstantin Khlebnikov <khlebnikov@openvz.org> wrote:
> This patch moves lru checks from __isolate_lru_page() to its callers.
>
> They aren't required on non-lumpy reclaim: all pages are came from right lru.
> Pages isolation on memory compaction should skip only unevictable pages.
> Thus we need to check page lru only on pages isolation for lumpy-reclaim.
>
> Plus this patch kills mem_cgroup_lru_del() and uses mem_cgroup_lru_del_list()
> instead, because now we already have lru list index.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
>
> add/remove: 0/1 grow/shrink: 2/1 up/down: 101/-164 (-63)
> function old new delta
> static.isolate_lru_pages 1018 1103 +85
> compact_zone 2230 2246 +16
> mem_cgroup_lru_del 65 - -65
> __isolate_lru_page 287 188 -99
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-03-13 5:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 18:03 [PATCH v5 0/7] mm: some cleanup/rework before lru_lock splitting Konstantin Khlebnikov
2012-03-08 18:04 ` [PATCH v5 1/7] mm/memcg: scanning_global_lru means mem_cgroup_disabled Konstantin Khlebnikov
2012-03-09 1:26 ` KAMEZAWA Hiroyuki
2012-03-08 18:04 ` [PATCH v5 2/7] mm/memcg: move reclaim_stat into lruvec Konstantin Khlebnikov
2012-03-09 1:27 ` KAMEZAWA Hiroyuki
2012-03-08 18:04 ` [PATCH v5 3/7] mm: push lru index into shrink_[in]active_list() Konstantin Khlebnikov
2012-03-09 1:28 ` KAMEZAWA Hiroyuki
2012-03-08 18:04 ` [PATCH v5 4/7] mm: rework __isolate_lru_page() page lru filter Konstantin Khlebnikov
2012-03-09 1:30 ` KAMEZAWA Hiroyuki
2012-03-08 18:04 ` [PATCH v5 5/7] mm: rework reclaim_stat counters Konstantin Khlebnikov
2012-03-09 1:32 ` KAMEZAWA Hiroyuki
2012-03-08 18:04 ` [PATCH v5 6/7] mm/memcg: rework inactive_ratio calculation Konstantin Khlebnikov
2012-03-08 18:04 ` [PATCH v5 7/7] mm/memcg: use vm_swappiness from target memory cgroup Konstantin Khlebnikov
2012-03-09 1:33 ` KAMEZAWA Hiroyuki
2012-03-11 14:36 ` [PATCH v5 4.5/7] mm: optimize isolate_lru_pages() Konstantin Khlebnikov
2012-03-13 5:26 ` KAMEZAWA Hiroyuki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313142635.a6a7b806.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=jweiner@redhat.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox