From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx173.postini.com [74.125.245.173]) by kanga.kvack.org (Postfix) with SMTP id 5D1D86B0044 for ; Mon, 12 Mar 2012 05:32:00 -0400 (EDT) Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 12 Mar 2012 14:59:07 +0530 Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q2C9SxE41925154 for ; Mon, 12 Mar 2012 14:59:00 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q2CEwCZu030497 for ; Tue, 13 Mar 2012 01:58:13 +1100 From: Srikar Dronamraju Date: Mon, 12 Mar 2012 14:56:06 +0530 Message-Id: <20120312092606.5379.87852.sendpatchset@srdronam.in.ibm.com> In-Reply-To: <20120312092514.5379.36595.sendpatchset@srdronam.in.ibm.com> References: <20120312092514.5379.36595.sendpatchset@srdronam.in.ibm.com> Subject: [PATCH v2 5/7] x86/trivial: Fix 'old_rsp' undefined build failure when including asm/compat.h Sender: owner-linux-mm@kvack.org List-ID: To: Peter Zijlstra , Ingo Molnar Cc: Andrew Morton , Linus Torvalds , Ananth N Mavinakayanahalli , Jim Keniston , LKML , Linux-mm , Oleg Nesterov , Andi Kleen , Christoph Hellwig , Steven Rostedt , Arnaldo Carvalho de Melo , Masami Hiramatsu , Thomas Gleixner From: Srikar Dronamraju Including asm/compat.h in arch/x86/kernel/signal.c and compiling on a i386 machine results in old_rsp undefined build errors. old_rsp is defined under CONFIG_X86_64. Hence add a i386 specific arch_compat_alloc_user_space that doesnt depend on old_rsp. Will be further cleaned up when is_ia32_compat_task is introduced. This is pure cleanup, no functional change intended. Signed-off-by: Srikar Dronamraju --- arch/x86/include/asm/compat.h | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/arch/x86/include/asm/compat.h b/arch/x86/include/asm/compat.h index 355edc0..ba9e9dc 100644 --- a/arch/x86/include/asm/compat.h +++ b/arch/x86/include/asm/compat.h @@ -221,6 +221,7 @@ static inline compat_uptr_t ptr_to_compat(void __user *uptr) return (u32)(unsigned long)uptr; } +#ifdef CONFIG_x86_64 static inline void __user *arch_compat_alloc_user_space(long len) { compat_uptr_t sp; @@ -234,6 +235,15 @@ static inline void __user *arch_compat_alloc_user_space(long len) return (void __user *)round_down(sp - len, 16); } +#else + +static inline void __user *arch_compat_alloc_user_space(long len) +{ + struct pt_regs *regs = task_pt_regs(current); + return (void __user *)regs->sp - len; +} + +#endif static inline bool is_ia32_task(void) { -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org