From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: Hugh Dickins <hughd@google.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Hillf Danton <dhillf@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] memcg: fix behavior of shard anon pages at task_move (Was Re: [PATCH v3 2/2] memcg: avoid THP split in task migration
Date: Fri, 9 Mar 2012 16:23:57 +0900 [thread overview]
Message-ID: <20120309162357.71c8c573.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20120309150109.51ba8ea1.nishimura@mxp.nes.nec.co.jp>
On Fri, 9 Mar 2012 15:01:09 +0900
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
> On Fri, 9 Mar 2012 12:24:48 +0900
> KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > > I'd rather delete than add code here!
> > >
> >
> > As a user, for Fujitsu, I believe it's insane to move task between cgroups.
> > So, I have no benefit from this code, at all.
> > Ok, maybe I'm not a stakeholder,here.
> >
> I agree that moving tasks between cgroup is not a sane operation,
> users won't do it so frequently, but I cannot prevent that.
> That's why I implemented this feature.
>
> > If users say all shared pages should be moved, ok, let's move.
> > But change of behavior should be documented and implemented in an independet
> > patch. CC'ed Nishimura-san, he implemetned this, a real user.
> >
> To be honest, shared anon is not my concern. My concern is
> shared memory(that's why, mapcount is not checked as for file pages.
> I assume all processes sharing the same shared memory will be moved together).
> So, it's all right for me to change the behavior for shared anon(or leave
> it as it is).
>
Thank you for comment. Then, here is a patch.
Other opinions ?
==
next prev parent reply other threads:[~2012-03-09 7:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 20:13 [PATCH v3 1/2] thp: add HPAGE_PMD_* definitions for !CONFIG_TRANSPARENT_HUGEPAGE Naoya Horiguchi
2012-03-02 20:13 ` [PATCH v3 2/2] memcg: avoid THP split in task migration Naoya Horiguchi
2012-03-09 0:30 ` Andrew Morton
2012-03-09 1:47 ` Naoya Horiguchi
2012-03-09 1:16 ` KAMEZAWA Hiroyuki
2012-03-09 2:33 ` Hugh Dickins
2012-03-09 3:24 ` KAMEZAWA Hiroyuki
2012-03-09 4:00 ` KAMEZAWA Hiroyuki
2012-03-09 6:01 ` Daisuke Nishimura
2012-03-09 7:23 ` KAMEZAWA Hiroyuki [this message]
2012-03-09 21:05 ` [PATCH] memcg: fix behavior of shard anon pages at task_move (Was " Hugh Dickins
2012-03-09 21:37 ` [PATCH] memcg: revert fix to mapcount check for this release Hugh Dickins
2012-03-09 22:46 ` Naoya Horiguchi
2012-03-13 5:13 ` KAMEZAWA Hiroyuki
2012-03-13 5:18 ` [PATCH] memcg: fix behavior of shard anon pages at task_move (Was Re: [PATCH v3 2/2] memcg: avoid THP split in task migration KAMEZAWA Hiroyuki
2012-03-09 4:25 ` Naoya Horiguchi
2012-03-09 7:32 ` KAMEZAWA Hiroyuki
2012-03-09 0:33 ` [PATCH v3 1/2] thp: add HPAGE_PMD_* definitions for !CONFIG_TRANSPARENT_HUGEPAGE KAMEZAWA Hiroyuki
2012-03-09 23:49 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120309162357.71c8c573.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dhillf@gmail.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox