From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx188.postini.com [74.125.245.188]) by kanga.kvack.org (Postfix) with SMTP id A724E6B0092 for ; Thu, 8 Mar 2012 00:50:31 -0500 (EST) Received: from m1.gw.fujitsu.co.jp (unknown [10.0.50.71]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id 42EAC3EE0C1 for ; Thu, 8 Mar 2012 14:50:30 +0900 (JST) Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 29AA445DE5E for ; Thu, 8 Mar 2012 14:50:30 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 100D345DE58 for ; Thu, 8 Mar 2012 14:50:30 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id E387CE08002 for ; Thu, 8 Mar 2012 14:50:29 +0900 (JST) Received: from ml13.s.css.fujitsu.com (ml13.s.css.fujitsu.com [10.240.81.133]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 9A16D1DB8049 for ; Thu, 8 Mar 2012 14:50:29 +0900 (JST) Date: Thu, 8 Mar 2012 14:48:55 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH] memcg: fix mapcount check in move charge code for anonymous page Message-Id: <20120308144855.271ed829.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <1330720508-21019-1-git-send-email-n-horiguchi@ah.jp.nec.com> References: <1330720508-21019-1-git-send-email-n-horiguchi@ah.jp.nec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Naoya Horiguchi Cc: linux-mm@kvack.org, Andrew Morton , Andrea Arcangeli , Daisuke Nishimura , Hillf Danton , linux-kernel@vger.kernel.org On Fri, 2 Mar 2012 15:35:08 -0500 Naoya Horiguchi wrote: > Currently charge on shared anonyous pages is supposed not to moved > in task migration. To implement this, we need to check that mapcount > 1, > instread of > 2. So this patch fixes it. > > Signed-off-by: Naoya Horiguchi Hm. I don't remember why this check uses mapcount > 2...maybe bug. Acked-by: KAMEZAWA Hiroyuki > --- > mm/memcontrol.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git linux-next-20120228.orig/mm/memcontrol.c linux-next-20120228/mm/memcontrol.c > index b6d1bab..785f6d3 100644 > --- linux-next-20120228.orig/mm/memcontrol.c > +++ linux-next-20120228/mm/memcontrol.c > @@ -5102,7 +5102,7 @@ static struct page *mc_handle_present_pte(struct vm_area_struct *vma, > return NULL; > if (PageAnon(page)) { > /* we don't move shared anon */ > - if (!move_anon() || page_mapcount(page) > 2) > + if (!move_anon() || page_mapcount(page) > 1) > return NULL; > } else if (!move_file()) > /* we ignore mapcount for file pages */ > -- > 1.7.7.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org