From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx173.postini.com [74.125.245.173]) by kanga.kvack.org (Postfix) with SMTP id 4ECA86B004A for ; Tue, 28 Feb 2012 19:52:26 -0500 (EST) Received: from m2.gw.fujitsu.co.jp (unknown [10.0.50.72]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id D70A73EE0BD for ; Wed, 29 Feb 2012 09:52:24 +0900 (JST) Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id B443C45DE4E for ; Wed, 29 Feb 2012 09:52:24 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 92BD645DD78 for ; Wed, 29 Feb 2012 09:52:24 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 7E9011DB803C for ; Wed, 29 Feb 2012 09:52:24 +0900 (JST) Received: from m107.s.css.fujitsu.com (m107.s.css.fujitsu.com [10.240.81.147]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 285E81DB802C for ; Wed, 29 Feb 2012 09:52:24 +0900 (JST) Date: Wed, 29 Feb 2012 09:50:51 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH 1/9] memcg: add page_cgroup flags for dirty page tracking Message-Id: <20120229095051.739bb363.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20120228144746.900395448@intel.com> References: <20120228140022.614718843@intel.com> <20120228144746.900395448@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Fengguang Wu Cc: Andrew Morton , Greg Thelen , Jan Kara , Ying Han , "hannes@cmpxchg.org" , Rik van Riel , Andrea Righi , Minchan Kim , Linux Memory Management List , LKML On Tue, 28 Feb 2012 22:00:23 +0800 Fengguang Wu wrote: > From: Greg Thelen > > Add additional flags to page_cgroup to track dirty pages > within a mem_cgroup. > > Signed-off-by: KAMEZAWA Hiroyuki > Signed-off-by: Andrea Righi > Signed-off-by: Greg Thelen > Reviewed-by: Minchan Kim > Signed-off-by: Fengguang Wu I'm sorry but I changed the design of page_cgroup's flags update and never want to add new flags (I'd like to remove page_cgroup->flags.) Please see linux-next. A good example is PCG_FILE_MAPPED, which I removed. memcg: use new logic for page stat accounting memcg: remove PCG_FILE_MAPPED You can make use of PageDirty() and PageWriteback() instead of new flags.. (I hope.) Thanks, -Kame > --- > include/linux/page_cgroup.h | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > --- linux.orig/include/linux/page_cgroup.h 2012-02-19 10:53:14.000000000 +0800 > +++ linux/include/linux/page_cgroup.h 2012-02-19 10:53:16.000000000 +0800 > @@ -10,6 +10,9 @@ enum { > /* flags for mem_cgroup and file and I/O status */ > PCG_MOVE_LOCK, /* For race between move_account v.s. following bits */ > PCG_FILE_MAPPED, /* page is accounted as "mapped" */ > + PCG_FILE_DIRTY, /* page is dirty */ > + PCG_FILE_WRITEBACK, /* page is under writeback */ > + PCG_FILE_UNSTABLE_NFS, /* page is NFS unstable */ > __NR_PCG_FLAGS, > }; > > @@ -64,6 +67,10 @@ static inline void ClearPageCgroup##unam > static inline int TestClearPageCgroup##uname(struct page_cgroup *pc) \ > { return test_and_clear_bit(PCG_##lname, &pc->flags); } > > +#define TESTSETPCGFLAG(uname, lname) \ > +static inline int TestSetPageCgroup##uname(struct page_cgroup *pc) \ > + { return test_and_set_bit(PCG_##lname, &pc->flags); } > + > /* Cache flag is set only once (at allocation) */ > TESTPCGFLAG(Cache, CACHE) > CLEARPCGFLAG(Cache, CACHE) > @@ -77,6 +84,22 @@ SETPCGFLAG(FileMapped, FILE_MAPPED) > CLEARPCGFLAG(FileMapped, FILE_MAPPED) > TESTPCGFLAG(FileMapped, FILE_MAPPED) > > +SETPCGFLAG(FileDirty, FILE_DIRTY) > +CLEARPCGFLAG(FileDirty, FILE_DIRTY) > +TESTPCGFLAG(FileDirty, FILE_DIRTY) > +TESTCLEARPCGFLAG(FileDirty, FILE_DIRTY) > +TESTSETPCGFLAG(FileDirty, FILE_DIRTY) > + > +SETPCGFLAG(FileWriteback, FILE_WRITEBACK) > +CLEARPCGFLAG(FileWriteback, FILE_WRITEBACK) > +TESTPCGFLAG(FileWriteback, FILE_WRITEBACK) > + > +SETPCGFLAG(FileUnstableNFS, FILE_UNSTABLE_NFS) > +CLEARPCGFLAG(FileUnstableNFS, FILE_UNSTABLE_NFS) > +TESTPCGFLAG(FileUnstableNFS, FILE_UNSTABLE_NFS) > +TESTCLEARPCGFLAG(FileUnstableNFS, FILE_UNSTABLE_NFS) > +TESTSETPCGFLAG(FileUnstableNFS, FILE_UNSTABLE_NFS) > + > SETPCGFLAG(Migration, MIGRATION) > CLEARPCGFLAG(Migration, MIGRATION) > TESTPCGFLAG(Migration, MIGRATION) > > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org