From: Johannes Weiner <hannes@cmpxchg.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Konstantin Khlebnikov <khlebnikov@openvz.org>,
Michal Hocko <mhocko@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] mm: memcg: count pte references from every member of the reclaimed hierarchy
Date: Wed, 29 Feb 2012 03:02:46 +0100 [thread overview]
Message-ID: <20120229020246.GF1702@cmpxchg.org> (raw)
In-Reply-To: <20120229093946.611a20d3.kamezawa.hiroyu@jp.fujitsu.com>
On Wed, Feb 29, 2012 at 09:39:46AM +0900, KAMEZAWA Hiroyuki wrote:
> On Tue, 28 Feb 2012 15:14:49 +0100
> Johannes Weiner <hannes@cmpxchg.org> wrote:
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -708,7 +708,8 @@ static enum page_references page_check_references(struct page *page,
> > int referenced_ptes, referenced_page;
> > unsigned long vm_flags;
> >
> > - referenced_ptes = page_referenced(page, 1, mz->mem_cgroup, &vm_flags);
> > + referenced_ptes = page_referenced(page, 1, sc->target_mem_cgroup,
> > + &vm_flags);
>
>
> I'm sorry if I don't understand the codes... !sc->target_mem_cgroup case is handled ?
Yes, but it's not obvious from the diff alone. page_referenced() does
this:
/*
* If we are reclaiming on behalf of a cgroup, skip
* counting on behalf of references from different
* cgroups
*/
if (memcg && !mm_match_cgroup(vma->vm_mm, memcg))
continue;
As a result, !sc->target_mem_cgroup -- global reclaim -- will never
ignore references, or put differently, respect references from all
memcgs, which is what we want.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-02-29 2:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 14:14 [patch 1/2] kernel: cgroup: push rcu read locking from css_is_ancestor() to callsite Johannes Weiner
2012-02-28 14:14 ` [patch 2/2] mm: memcg: count pte references from every member of the reclaimed hierarchy Johannes Weiner
2012-02-28 15:46 ` Konstantin Khlebnikov
2012-02-29 0:39 ` KAMEZAWA Hiroyuki
2012-02-29 2:02 ` Johannes Weiner [this message]
2012-02-29 3:08 ` KAMEZAWA Hiroyuki
2012-03-14 14:25 ` Michal Hocko
2012-03-14 16:21 ` Johannes Weiner
2012-03-14 17:53 ` Michal Hocko
2012-03-14 17:54 ` Michal Hocko
2012-02-29 0:00 ` [patch 1/2] kernel: cgroup: push rcu read locking from css_is_ancestor() to callsite KAMEZAWA Hiroyuki
2012-03-01 1:38 ` Li Zefan
2012-03-14 12:41 ` Michal Hocko
2012-04-24 19:35 Johannes Weiner
2012-04-24 19:35 ` [patch 2/2] mm: memcg: count pte references from every member of the reclaimed hierarchy Johannes Weiner
2012-04-25 3:52 ` Konstantin Khlebnikov
2012-04-26 21:37 ` Andrew Morton
2012-04-26 23:48 ` Johannes Weiner
2012-04-27 8:10 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229020246.GF1702@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox