From: Mel Gorman <mel@csn.ul.ie>
To: Rik van Riel <riel@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, bugzilla-daemon@bugzilla.kernel.org,
Stuart Foster <smf.linux@ntlworld.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [Bug 42578] Kernel crash "Out of memory error by X" when using NTFS file system on external USB Hard drive
Date: Tue, 14 Feb 2012 12:17:42 +0000 [thread overview]
Message-ID: <20120214121742.GJ17917@csn.ul.ie> (raw)
In-Reply-To: <4F354D51.7020408@redhat.com>
On Fri, Feb 10, 2012 at 12:01:05PM -0500, Rik van Riel wrote:
> On 02/10/2012 11:37 AM, Mel Gorman wrote:
> >On Thu, Jan 19, 2012 at 12:24:48PM -0800, Andrew Morton wrote:
>
> >>I think it is was always wrong that we only strip buffer_heads when
> >>moving pages to the inactive list. What happens if those 600MB of
> >>buffer_heads are all attached to inactive pages?
> >>
> >
> >I wondered the same thing myself. With some use-once logic, there is
> >no guarantee that they even get promoted to the active list in the
> >first place. It's "always" been like this but we've changed how pages gets
> >promoted quite a bit and this use case could have been easily missed.
>
> It may be possible to also strip the buffer heads from
> pages when they are moved to the active list, in
> activate_page().
>
It'd be possible but is that really the right thing to do? I am thinking
about when we call mark_page_accessed via touch_buffer, __find_get_block
etc. In those paths, is it not implied the buffer_heads are in active use
and releasing them would be counter-productive?
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-02-14 12:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-42578-27@https.bugzilla.kernel.org/>
[not found] ` <201201180922.q0I9MCYl032623@bugzilla.kernel.org>
2012-01-19 20:24 ` Andrew Morton
2012-02-10 16:37 ` Mel Gorman
2012-02-10 17:01 ` Rik van Riel
2012-02-14 12:17 ` Mel Gorman [this message]
2012-02-11 21:28 ` Stuart Foster
2012-02-14 13:09 ` Mel Gorman
2012-02-14 20:00 ` Christoph Lameter
2012-02-14 20:34 ` Andrew Morton
2012-02-14 20:42 ` Christoph Lameter
2012-02-14 20:37 ` Andrew Morton
2012-02-15 13:57 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120214121742.GJ17917@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=akpm@linux-foundation.org \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=smf.linux@ntlworld.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox