From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx179.postini.com [74.125.245.179]) by kanga.kvack.org (Postfix) with SMTP id BF56C6B002C for ; Wed, 8 Feb 2012 21:21:10 -0500 (EST) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id 4CA7D3EE0BD for ; Thu, 9 Feb 2012 11:21:09 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 2F2D145DFA4 for ; Thu, 9 Feb 2012 11:21:09 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 16D0245DF9F for ; Thu, 9 Feb 2012 11:21:09 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 061321DB8042 for ; Thu, 9 Feb 2012 11:21:09 +0900 (JST) Received: from m107.s.css.fujitsu.com (m107.s.css.fujitsu.com [10.240.81.147]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id B1B331DB803B for ; Thu, 9 Feb 2012 11:21:08 +0900 (JST) Date: Thu, 9 Feb 2012 11:19:50 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH 2/6] thp: optimize away unnecessary page table locking Message-Id: <20120209111950.b3e626d1.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <1328716302-16871-3-git-send-email-n-horiguchi@ah.jp.nec.com> References: <1328716302-16871-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1328716302-16871-3-git-send-email-n-horiguchi@ah.jp.nec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Naoya Horiguchi Cc: linux-mm@kvack.org, Andrew Morton , David Rientjes , Andi Kleen , Wu Fengguang , Andrea Arcangeli , KOSAKI Motohiro , linux-kernel@vger.kernel.org On Wed, 8 Feb 2012 10:51:38 -0500 Naoya Horiguchi wrote: > Currently when we check if we can handle thp as it is or we need to > split it into regular sized pages, we hold page table lock prior to > check whether a given pmd is mapping thp or not. Because of this, > when it's not "huge pmd" we suffer from unnecessary lock/unlock overhead. > To remove it, this patch introduces a optimized check function and > replace several similar logics with it. > > Signed-off-by: Naoya Horiguchi > Cc: David Rientjes > I prefer 'bool' for return type..but seems much better. Thank you. I think this clean up is very good. Reviewed-by: KAMEZAWA Hiroyuki -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org