From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx121.postini.com [74.125.245.121]) by kanga.kvack.org (Postfix) with SMTP id 4EF446B13F1 for ; Fri, 3 Feb 2012 09:53:08 -0500 (EST) Date: Fri, 3 Feb 2012 15:53:04 +0100 From: Michal Hocko Subject: Re: [PATCH] Handling of unused variable 'do-numainfo on compilation time Message-ID: <20120203145304.GA18335@tiehlicka.suse.cz> References: <1328258627-2241-1-git-send-email-geunsik.lim@gmail.com> <20120203133950.GA1690@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120203133950.GA1690@cmpxchg.org> Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: KAMEZAWA Hiroyuki , Andrew Morton , linux-kernel , Daisuke Nishimura , Geunsik Lim , linux-mm On Fri 03-02-12 14:39:50, Johannes Weiner wrote: > Michal, this keeps coming up, please decide between the proposed > solutions ;-) Hmm, I thought we already sorted this out https://lkml.org/lkml/2012/1/26/25 ? > > On Fri, Feb 03, 2012 at 05:43:47PM +0900, Geunsik Lim wrote: > > Actually, Usage of the variable 'do_numainfo'is not suitable for gcc compiler. > > Declare the variable 'do_numainfo' if the number of NUMA nodes > 1. > > > > Signed-off-by: Geunsik Lim > > --- > > mm/memcontrol.c | 5 ++++- > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 556859f..4e17ac5 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -776,7 +776,10 @@ static void memcg_check_events(struct mem_cgroup *memcg, struct page *page) > > /* threshold event is triggered in finer grain than soft limit */ > > if (unlikely(mem_cgroup_event_ratelimit(memcg, > > MEM_CGROUP_TARGET_THRESH))) { > > - bool do_softlimit, do_numainfo; > > + bool do_softlimit; > > +#if MAX_NUMNODES > 1 > > + bool do_numainfo; > > +#endif > > > > do_softlimit = mem_cgroup_event_ratelimit(memcg, > > MEM_CGROUP_TARGET_SOFTLIMIT); > > -- > > 1.7.8.1 > > -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org