From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sumit Semwal <sumit.semwal@ti.com>,
linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org
Subject: Re: [Linaro-mm-sig] [PATCH 4/4] dma-buf: Move code out of mutex-protected section in dma_buf_attach()
Date: Thu, 26 Jan 2012 13:37:43 +0100 [thread overview]
Message-ID: <20120126123743.GH3896@phenom.ffwll.local> (raw)
In-Reply-To: <e0d58a$3259e0@orsmga002.jf.intel.com>
On Thu, Jan 26, 2012 at 12:11:57PM +0000, Chris Wilson wrote:
> On Thu, 26 Jan 2012 12:27:25 +0100, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> > Some fields can be set without mutex protection. Initialize them before
> > locking the mutex.
>
> struct mutex lock is described as
>
> /* mutex to serialize list manipulation and other ops */
>
> maybe now is a good time to be a little more descriptive in what that
> mutex is meant to protect and sprinkle enforcement throughout the code
> as a means of documentation.
As, sore spot there. I think the current locking scheme is rather much
still in flux. I think we need to pull out callbacks to the exporter out
from the dma_buf mutex because otherwise we won't be able to avoid
deadlocks.
I think we'll need to wait for 1-2 exporters to show up in upstream until
we can clarify this. But it is very much on my list.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-01-26 12:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 11:27 [PATCH 0/4] Miscellaneous dma-buf patches Laurent Pinchart
2012-01-26 11:27 ` [PATCH 1/4] dma-buf: Constify ops argument to dma_buf_export() Laurent Pinchart
2012-01-26 11:32 ` [Linaro-mm-sig] " Daniel Vetter
2012-01-26 11:27 ` [PATCH 2/4] dma-buf: Remove unneeded sanity checks Laurent Pinchart
2012-01-26 11:35 ` [Linaro-mm-sig] " Daniel Vetter
2012-01-26 11:27 ` [PATCH 3/4] dma-buf: Return error instead of using a goto statement when possible Laurent Pinchart
2012-01-26 11:35 ` [Linaro-mm-sig] " Daniel Vetter
2012-01-26 11:27 ` [PATCH 4/4] dma-buf: Move code out of mutex-protected section in dma_buf_attach() Laurent Pinchart
2012-01-26 11:36 ` [Linaro-mm-sig] " Daniel Vetter
2012-01-26 12:11 ` Chris Wilson
2012-01-26 12:37 ` Daniel Vetter [this message]
2012-01-27 5:19 ` [PATCH 0/4] Miscellaneous dma-buf patches Sumit Semwal
2012-03-21 11:20 ` Laurent Pinchart
2012-03-21 11:42 ` Sumit Semwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120126123743.GH3896@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-mm@kvack.org \
--cc=sumit.semwal@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox