From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx169.postini.com [74.125.245.169]) by kanga.kvack.org (Postfix) with SMTP id 537AB6B004D for ; Fri, 20 Jan 2012 05:34:07 -0500 (EST) Date: Fri, 20 Jan 2012 11:33:57 +0100 From: Johannes Weiner Subject: Re: [PATCH v3] memcg: remove PCG_CACHE page_cgroup flag Message-ID: <20120120103356.GT24386@cmpxchg.org> References: <20120119181711.8d697a6b.kamezawa.hiroyu@jp.fujitsu.com> <20120120122658.1b14b512.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120120122658.1b14b512.kamezawa.hiroyu@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org List-ID: To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , Michal Hocko , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , Hugh Dickins , Ying Han On Fri, Jan 20, 2012 at 12:26:58PM +0900, KAMEZAWA Hiroyuki wrote: > I think this version is much simplified. > > == > >From 5700a4fe9c581e1ebaa021ba6119dc8d921b024f Mon Sep 17 00:00:00 2001 > From: KAMEZAWA Hiroyuki > Date: Thu, 19 Jan 2012 17:09:41 +0900 > Subject: [PATCH v3] memcg: remove PCG_CACHE > > We record 'the page is cache' by PCG_CACHE bit to page_cgroup. > Here, "CACHE" means anonymous user pages (and SwapCache). This > doesn't include shmem. > > Consdering callers, at charge/uncharge, the caller should know > what the page is and we don't need to record it by using 1bit > per page. > > This patch removes PCG_CACHE bit and make callers of > mem_cgroup_charge_statistics() to specify what the page is. > > Changelog since v2 > - removed 'not_rss', added 'anon' > - changed a meaning of arguments to mem_cgroup_charge_statisitcs() > - removed a patch to mem_cgroup_uncharge_cache > - simplified comment. > > Changelog since RFC. > - rebased onto memcg-devel > - rename 'file' to 'not_rss' > - some cleanup and added comment. > > Signed-off-by: KAMEZAWA Hiroyuki Apart from Michal's rss -> anon renaming suggestion, which I agree with: Acked-by: Johannes Weiner -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org