From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx127.postini.com [74.125.245.127]) by kanga.kvack.org (Postfix) with SMTP id 98B336B004D for ; Tue, 17 Jan 2012 18:57:20 -0500 (EST) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id BDE903EE0C2 for ; Wed, 18 Jan 2012 08:57:18 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id A531E45DEDC for ; Wed, 18 Jan 2012 08:57:18 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 7AB5345DEEA for ; Wed, 18 Jan 2012 08:57:18 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 6FA4A1DB803F for ; Wed, 18 Jan 2012 08:57:18 +0900 (JST) Received: from ml14.s.css.fujitsu.com (ml14.s.css.fujitsu.com [10.240.81.134]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 2B7BA1DB803B for ; Wed, 18 Jan 2012 08:57:18 +0900 (JST) Date: Wed, 18 Jan 2012 08:55:58 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [RFC] [PATCH 1/7 v2] memcg: remove unnecessary check in mem_cgroup_update_page_stat() Message-Id: <20120118085558.6ed1a988.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20120117151619.GA21348@tiehlicka.suse.cz> References: <20120113173001.ee5260ca.kamezawa.hiroyu@jp.fujitsu.com> <20120113173227.df2baae3.kamezawa.hiroyu@jp.fujitsu.com> <20120117151619.GA21348@tiehlicka.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: "linux-mm@kvack.org" , Ying Han , "hugh.dickins@tiscali.co.uk" , "hannes@cmpxchg.org" , cgroups@vger.kernel.org, "bsingharora@gmail.com" On Tue, 17 Jan 2012 16:16:20 +0100 Michal Hocko wrote: > On Fri 13-01-12 17:32:27, KAMEZAWA Hiroyuki wrote: > > > > From 788aebf15f3fa37940e0745cab72547e20683bf2 Mon Sep 17 00:00:00 2001 > > From: KAMEZAWA Hiroyuki > > Date: Thu, 12 Jan 2012 16:08:33 +0900 > > Subject: [PATCH 1/7] memcg: remove unnecessary check in mem_cgroup_update_page_stat() > > > > commit 10ea69f1182b removes move_lock_page_cgroup() in thp-split path. > > So, this PageTransHuge() check is unnecessary, too. > > I do not see commit like that in the tree. I guess you meant > memcg: make mem_cgroup_split_huge_fixup() more efficient which is not > merged yet, right? > This commit in the linux-next. > commit e94c8a9cbce1aee4af9e1285802785481b7f93c5 > Author: KAMEZAWA Hiroyuki > Date: Thu Jan 12 17:18:20 2012 -0800 > > memcg: make mem_cgroup_split_huge_fixup() more efficient > > > > > Note: > > - considering when mem_cgroup_update_page_stat() is called, > > there will be no race between split_huge_page() and update_page_stat(). > > All required locks are held in higher level. > > We should never have THP page in this path in the first place. So why > not changing this to VM_BUG_ON(PageTransHuge). > Ying Han considers to support mlock stat. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org