From: Andi Kleen <andi@firstfloor.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andi Kleen <andi@firstfloor.org>,
Peter Zijlstra <peterz@infradead.org>,
Mel Gorman <mgorman@suse.de>, Christoph Lameter <cl@linux.com>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [RFC][PATCH] mm: Remove NUMA_INTERLEAVE_HIT
Date: Thu, 12 Jan 2012 23:29:29 +0100 [thread overview]
Message-ID: <20120112222929.GI11715@one.firstfloor.org> (raw)
In-Reply-To: <20120112134045.552e2a61.akpm@linux-foundation.org>
On Thu, Jan 12, 2012 at 01:40:45PM -0800, Andrew Morton wrote:
> On Thu, 12 Jan 2012 22:07:43 +0100
> Andi Kleen <andi@firstfloor.org> wrote:
>
> > On Thu, Jan 12, 2012 at 09:13:47PM +0100, Peter Zijlstra wrote:
> > > On Thu, 2012-01-12 at 19:26 +0100, Andi Kleen wrote:
> > > > This would break the numactl testsuite.
> > > >
> > > How so? The userspace output will still contain the field, we'll simply
> > > always print 0.
> >
> > Then the interleave test in the test suite will fail
> >
> > >
> > > But if you want I can provide a patch for numactl.
> >
> > Disable the test? That would be bad too.
> >
>
> My googling and codesearch attempts didn't reveal any users of
> NUMA_INTERLEAVE_HIT. But then, it didn't find the usage in the numactl
Obviously you have to search for "interleave_hit", the uppercase variant is
just an kernel internal define.
> suite either.
test/regress
>
> It would be good if we could find some way to remove this code (and any
> other code!). If that causes a bit of pain for users of the test suite
> (presumably a small number of technically able people) then that seems
> acceptable to me - we end up with a better kernel.
The problem is that then there will be nothing left that actually
tests interleaving. The numactl has caught kernel regressions in the past.
I don't think disabling useful regression tests is a good idea.
In contrary the kernel needs far more of them, not less.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-01-12 22:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 15:07 Peter Zijlstra
2012-01-12 17:37 ` Christoph Lameter
2012-01-12 18:26 ` Andi Kleen
2012-01-12 19:02 ` KOSAKI Motohiro
2012-01-12 19:10 ` Andi Kleen
2012-01-12 20:13 ` Peter Zijlstra
2012-01-12 21:07 ` Andi Kleen
2012-01-12 21:40 ` Andrew Morton
2012-01-12 22:29 ` Andi Kleen [this message]
2012-01-13 15:28 ` Christoph Lameter
2012-01-13 18:39 ` Andi Kleen
2012-01-13 19:28 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120112222929.GI11715@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox