linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	containers@lists.linux-foundation.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Balbir Singh <bsingharora@gmail.com>,
	Michal Hocko <mhocko@suse.cz>,
	stable@kernel.org
Subject: Re: [RESEND, PATCH 4/6] memcg: fix broken boolean expression
Date: Mon, 9 Jan 2012 15:04:04 +0100	[thread overview]
Message-ID: <20120109140404.GG3588@cmpxchg.org> (raw)
In-Reply-To: <1325883472-5614-4-git-send-email-kirill@shutemov.name>

On Fri, Jan 06, 2012 at 10:57:50PM +0200, Kirill A. Shutemov wrote:
> From: "Kirill A. Shutemov" <kirill@shutemov.name>
> 
> action != CPU_DEAD || action != CPU_DEAD_FROZEN is always true.
> 
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> Cc: <stable@kernel.org>

I think you don't need to actually CC stable via email.  If you
include that tag, they will pick it up once the patch hits mainline.

The changelog is too terse, doubly so for a patch that should go into
stable.  How is the code supposed to work?  What are the consequences
of the bug?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-01-09 14:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-06 20:57 [RESEND, PATCH 1/6] memcg: mark more functions/variables as static Kirill A. Shutemov
2012-01-06 20:57 ` [RESEND, PATCH 2/6] memcg: remove unused variable Kirill A. Shutemov
2012-01-06 20:57 ` [RESEND, PATCH 3/6] memcg: mark stat field of mem_cgroup struct as __percpu Kirill A. Shutemov
2012-01-06 20:57 ` [RESEND, PATCH 4/6] memcg: fix broken boolean expression Kirill A. Shutemov
2012-01-09 14:04   ` Johannes Weiner [this message]
2012-01-16 11:54     ` Kirill A. Shutemov
2012-01-19 13:44       ` Johannes Weiner
2012-01-06 20:57 ` [RESEND, PATCH 5/6] memcg: drop redundant brackets Kirill A. Shutemov
2012-01-06 20:57 ` [RESEND, PATCH 6/6] memcg: cleanup memcg_check_events() Kirill A. Shutemov
2012-01-09 13:41   ` Johannes Weiner
2012-01-16 11:59     ` Kirill A. Shutemov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120109140404.GG3588@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=bsingharora@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox