From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx122.postini.com [74.125.245.122]) by kanga.kvack.org (Postfix) with SMTP id B736A6B004D for ; Wed, 4 Jan 2012 04:01:05 -0500 (EST) Date: Wed, 4 Jan 2012 10:01:03 +0100 From: Michal Hocko Subject: Re: [PATCH 2/2] memcg: mark rcu protected member as __rcu Message-ID: <20120104090102.GB12581@tiehlicka.suse.cz> References: <1325633632-9978-1-git-send-email-kosaki.motohiro@gmail.com> <1325633632-9978-2-git-send-email-kosaki.motohiro@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1325633632-9978-2-git-send-email-kosaki.motohiro@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: kosaki.motohiro@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, KOSAKI Motohiro , KAMEZAWA Hiroyuki , Johannes Weiner , cgroups@vger.kernel.org On Tue 03-01-12 18:33:52, kosaki.motohiro@gmail.com wrote: > From: KOSAKI Motohiro > > Currently "make C=2 mm/memcontrol.o" makes following warnings. fix it. > > mm/memcontrol.c:4243:21: error: incompatible types in comparison expression (different address spaces) > mm/memcontrol.c:4245:21: error: incompatible types in comparison expression (different address spaces) > > Signed-off-by: KOSAKI Motohiro > Cc: KAMEZAWA Hiroyuki > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: cgroups@vger.kernel.org Looks correct. Acked-by: Michal Hocko Thanks > --- > mm/memcontrol.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 6adeeec..138be2b 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -195,7 +195,7 @@ struct mem_cgroup_threshold_ary { > > struct mem_cgroup_thresholds { > /* Primary thresholds array */ > - struct mem_cgroup_threshold_ary *primary; > + struct mem_cgroup_threshold_ary __rcu *primary; > /* > * Spare threshold array. > * This is needed to make mem_cgroup_unregister_event() "never fail". > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe cgroups" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org