From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx175.postini.com [74.125.245.175]) by kanga.kvack.org (Postfix) with SMTP id 49E2E6B004D for ; Mon, 2 Jan 2012 08:03:28 -0500 (EST) Date: Mon, 2 Jan 2012 14:03:10 +0100 From: Michal Hocko Subject: Re: [PATCH 5/5] memcg: remove redundant returns Message-ID: <20120102130310.GI7910@tiehlicka.suse.cz> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Hugh Dickins Cc: Andrew Morton , KAMEZAWA Hiroyuki , Johannes Weiner , Balbir Singh , KOSAKI Motohiro , linux-mm@kvack.org On Sat 31-12-11 23:33:24, Hugh Dickins wrote: > Remove redundant returns from ends of functions, and one blank line. > > Signed-off-by: Hugh Dickins Acked-by: Michal Hocko > --- > mm/memcontrol.c | 5 ----- > 1 file changed, 5 deletions(-) > > --- mmotm.orig/mm/memcontrol.c 2011-12-30 21:29:03.695349263 -0800 > +++ mmotm/mm/memcontrol.c 2011-12-30 21:29:37.611350065 -0800 > @@ -1362,7 +1362,6 @@ void mem_cgroup_print_oom_info(struct me > if (!memcg || !p) > return; > > - > rcu_read_lock(); > > mem_cgrp = memcg->css.cgroup; > @@ -1897,7 +1896,6 @@ out: > if (unlikely(need_unlock)) > move_unlock_page_cgroup(pc, &flags); > rcu_read_unlock(); > - return; > } > EXPORT_SYMBOL(mem_cgroup_update_page_stat); > > @@ -2691,7 +2689,6 @@ __mem_cgroup_commit_charge_lrucare(struc > SetPageLRU(page); > } > spin_unlock_irqrestore(&zone->lru_lock, flags); > - return; > } > > int mem_cgroup_cache_charge(struct page *page, struct mm_struct *mm, > @@ -2881,7 +2878,6 @@ direct_uncharge: > res_counter_uncharge(&memcg->memsw, nr_pages * PAGE_SIZE); > if (unlikely(batch->memcg != memcg)) > memcg_oom_recover(memcg); > - return; > } > > /* > @@ -3935,7 +3931,6 @@ static void memcg_get_hierarchical_limit > out: > *mem_limit = min_limit; > *memsw_limit = min_memsw_limit; > - return; > } > > static int mem_cgroup_reset(struct cgroup *cont, unsigned int event) -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org