From: Michal Hocko <mhocko@suse.cz>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Balbir Singh <bsingharora@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
linux-mm@kvack.org
Subject: Re: [PATCH 5/5] memcg: remove redundant returns
Date: Mon, 2 Jan 2012 14:03:10 +0100 [thread overview]
Message-ID: <20120102130310.GI7910@tiehlicka.suse.cz> (raw)
In-Reply-To: <alpine.LSU.2.00.1112312331590.18500@eggly.anvils>
On Sat 31-12-11 23:33:24, Hugh Dickins wrote:
> Remove redundant returns from ends of functions, and one blank line.
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
Acked-by: Michal Hocko <mhocko@suse.cz>
> ---
> mm/memcontrol.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> --- mmotm.orig/mm/memcontrol.c 2011-12-30 21:29:03.695349263 -0800
> +++ mmotm/mm/memcontrol.c 2011-12-30 21:29:37.611350065 -0800
> @@ -1362,7 +1362,6 @@ void mem_cgroup_print_oom_info(struct me
> if (!memcg || !p)
> return;
>
> -
> rcu_read_lock();
>
> mem_cgrp = memcg->css.cgroup;
> @@ -1897,7 +1896,6 @@ out:
> if (unlikely(need_unlock))
> move_unlock_page_cgroup(pc, &flags);
> rcu_read_unlock();
> - return;
> }
> EXPORT_SYMBOL(mem_cgroup_update_page_stat);
>
> @@ -2691,7 +2689,6 @@ __mem_cgroup_commit_charge_lrucare(struc
> SetPageLRU(page);
> }
> spin_unlock_irqrestore(&zone->lru_lock, flags);
> - return;
> }
>
> int mem_cgroup_cache_charge(struct page *page, struct mm_struct *mm,
> @@ -2881,7 +2878,6 @@ direct_uncharge:
> res_counter_uncharge(&memcg->memsw, nr_pages * PAGE_SIZE);
> if (unlikely(batch->memcg != memcg))
> memcg_oom_recover(memcg);
> - return;
> }
>
> /*
> @@ -3935,7 +3931,6 @@ static void memcg_get_hierarchical_limit
> out:
> *mem_limit = min_limit;
> *memsw_limit = min_memsw_limit;
> - return;
> }
>
> static int mem_cgroup_reset(struct cgroup *cont, unsigned int event)
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-01-02 13:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-01 7:26 [PATCH 0/5] memcg: trivial cleanups Hugh Dickins
2012-01-01 7:27 ` [PATCH 1/5] memcg: replace MEM_CONT by MEM_RES_CTLR Hugh Dickins
2012-01-01 7:33 ` KOSAKI Motohiro
2012-01-02 11:53 ` Michal Hocko
2012-01-05 6:30 ` KAMEZAWA Hiroyuki
2012-01-01 7:29 ` [PATCH 2/5] memcg: replace mem and mem_cont stragglers Hugh Dickins
2012-01-01 7:34 ` KOSAKI Motohiro
2012-01-02 12:25 ` Michal Hocko
2012-01-05 6:31 ` KAMEZAWA Hiroyuki
2012-01-01 7:30 ` [PATCH 3/5] memcg: lru_size instead of MEM_CGROUP_ZSTAT Hugh Dickins
2012-01-01 7:37 ` KOSAKI Motohiro
2012-01-02 12:59 ` Michal Hocko
2012-01-02 19:43 ` Hugh Dickins
2012-01-03 11:05 ` Michal Hocko
2012-01-05 6:33 ` KAMEZAWA Hiroyuki
2012-01-05 20:14 ` Hugh Dickins
2012-01-01 7:31 ` [PATCH 4/5] memcg: enum lru_list lru Hugh Dickins
2012-01-01 7:38 ` KOSAKI Motohiro
2012-01-02 13:01 ` Michal Hocko
2012-01-05 6:34 ` KAMEZAWA Hiroyuki
2012-01-01 7:33 ` [PATCH 5/5] memcg: remove redundant returns Hugh Dickins
2012-01-01 7:38 ` KOSAKI Motohiro
2012-01-02 13:03 ` Michal Hocko [this message]
2012-01-05 6:35 ` KAMEZAWA Hiroyuki
2012-01-01 17:01 ` [PATCH 0/5] memcg: trivial cleanups Kirill A. Shutemov
2012-01-09 13:03 ` Johannes Weiner
2012-01-15 0:07 ` Hugh Dickins
2012-01-15 0:09 ` [PATCH 1/5] memcg: replace MEM_CONT by MEM_RES_CTLR Hugh Dickins
2012-01-15 0:10 ` [PATCH 2/5] memcg: replace mem and mem_cont stragglers Hugh Dickins
2012-01-15 0:12 ` [PATCH 3/5] memcg: lru_size instead of MEM_CGROUP_ZSTAT Hugh Dickins
2012-01-15 0:13 ` [PATCH 4/5] memcg: enum lru_list lru Hugh Dickins
2012-01-15 0:14 ` [PATCH 5/5] memcg: remove redundant returns Hugh Dickins
2012-01-16 9:47 ` [PATCH 0/5] memcg: trivial cleanups Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120102130310.GI7910@tiehlicka.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox