From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx125.postini.com [74.125.245.125]) by kanga.kvack.org (Postfix) with SMTP id D80766B004F for ; Mon, 26 Dec 2011 19:22:10 -0500 (EST) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id C23053EE0BC for ; Tue, 27 Dec 2011 09:22:08 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id A7B2B45DEA6 for ; Tue, 27 Dec 2011 09:22:08 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 80D8945DEAD for ; Tue, 27 Dec 2011 09:22:08 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 738841DB8040 for ; Tue, 27 Dec 2011 09:22:08 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.240.81.145]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 2CC9E1DB8038 for ; Tue, 27 Dec 2011 09:22:08 +0900 (JST) Date: Tue, 27 Dec 2011 09:20:52 +0900 From: KAMEZAWA Hiroyuki Subject: Re: Kswapd in 3.2.0-rc5 is a CPU hog Message-Id: <20111227092052.f2b02637.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: References: <1324437036.4677.5.camel@hakkenden.homenet> <20111221095249.GA28474@tiehlicka.suse.cz> <20111221225512.GG23662@dastard> <1324630880.562.6.camel@rybalov.eng.ttk.net> <20111223102027.GB12731@dastard> <1324638242.562.15.camel@rybalov.eng.ttk.net> <20111223204503.GC12731@dastard> <1324808519.29243.8.camel@hakkenden.homenet> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Hillf Danton Cc: "Nikolay S." , Dave Chinner , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Mon, 26 Dec 2011 20:35:46 +0800 Hillf Danton wrote: > On Sun, Dec 25, 2011 at 6:21 PM, Nikolay S. wrote: > > > > Uhm.., is this patch against 3.2-rc4? I can not apply it. There's no > > mem_cgroup_lru_del_list(), but void mem_cgroup_del_lru_list(). Should I > > place changes there? > > > > And also, -rc7 is here. May the problem be addressed as part of some > > ongoing work? Is there any reason to try -rc7 (the problem requires > > several days of uptime to become obvious)? > > > > Sorry, Nikolay, it is not based on the -next, nor on the -rc5(I assumed it was). > The following is based on -next, and if you want to test -rc5, please > grep MEM_CGROUP_ZSTAT mm/memcontrol.c and change it. > > Best regard > Hmm ? memcg is used ? Why do you consider this will be a help ? Thanks, -Kame > Hillf > --- > > --- a/mm/memcontrol.c Mon Dec 26 20:34:38 2011 > +++ b/mm/memcontrol.c Mon Dec 26 20:37:54 2011 > @@ -1076,7 +1076,11 @@ void mem_cgroup_lru_del_list(struct page > VM_BUG_ON(!memcg); > mz = page_cgroup_zoneinfo(memcg, page); > /* huge page split is done under lru_lock. so, we have no races. */ > - MEM_CGROUP_ZSTAT(mz, lru) -= 1 << compound_order(page); > + if (WARN_ON_ONCE(MEM_CGROUP_ZSTAT(mz, lru) < > + (1 << compound_order(page)))) > + MEM_CGROUP_ZSTAT(mz, lru) = 0; > + else > + MEM_CGROUP_ZSTAT(mz, lru) -= 1 << compound_order(page); > } > > void mem_cgroup_lru_del(struct page *page) > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ > Don't email: email@kvack.org > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org