From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx141.postini.com [74.125.245.141]) by kanga.kvack.org (Postfix) with SMTP id 037546B004F for ; Mon, 26 Dec 2011 01:51:21 -0500 (EST) Received: from m1.gw.fujitsu.co.jp (unknown [10.0.50.71]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id 84B9E3EE0C3 for ; Mon, 26 Dec 2011 15:51:20 +0900 (JST) Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 6B5DC45DE58 for ; Mon, 26 Dec 2011 15:51:20 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 501A545DE3E for ; Mon, 26 Dec 2011 15:51:20 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 440201DB8049 for ; Mon, 26 Dec 2011 15:51:20 +0900 (JST) Received: from m107.s.css.fujitsu.com (m107.s.css.fujitsu.com [10.240.81.147]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id EB7481DB8045 for ; Mon, 26 Dec 2011 15:51:19 +0900 (JST) Date: Mon, 26 Dec 2011 15:50:08 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH 1/6] memcg: fix unused variable warning Message-Id: <20111226155008.9ab21c6f.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20111226064734.GA13355@shutemov.name> References: <1324695619-5537-1-git-send-email-kirill@shutemov.name> <20111226152531.e0335ec4.kamezawa.hiroyu@jp.fujitsu.com> <20111226063652.GA13273@shutemov.name> <20111226154252.d3621532.kamezawa.hiroyu@jp.fujitsu.com> <20111226064734.GA13355@shutemov.name> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, Balbir Singh , Michal Hocko , Johannes Weiner On Mon, 26 Dec 2011 08:47:34 +0200 "Kirill A. Shutemov" wrote: > On Mon, Dec 26, 2011 at 03:42:52PM +0900, KAMEZAWA Hiroyuki wrote: > > On Mon, 26 Dec 2011 08:36:52 +0200 > > "Kirill A. Shutemov" wrote: > > > > > On Mon, Dec 26, 2011 at 03:25:31PM +0900, KAMEZAWA Hiroyuki wrote: > > > > On Sat, 24 Dec 2011 05:00:14 +0200 > > > > "Kirill A. Shutemov" wrote: > > > > > > > > > From: "Kirill A. Shutemov" > > > > > > > > > > mm/memcontrol.c: In function ‘memcg_check_events’: > > > > > mm/memcontrol.c:784:22: warning: unused variable ‘do_numainfo’ [-Wunused-variable] > > > > > > > > > > Signed-off-by: Kirill A. Shutemov > > > > > > > > Hmm ? Doesn't this fix cause a new Warning ? > > > > > > > > mm/memcontrol.c: In function ?memcg_check_events?: > > > > mm/memcontrol.c:789: warning: ISO C90 forbids mixed declarations and code > > > > > > I don't see how. The result code is: > > > > > > if (unlikely(mem_cgroup_event_ratelimit(memcg, > > > MEM_CGROUP_TARGET_THRESH))) { > > > bool do_softlimit; > > > > > > #if MAX_NUMNODES > 1 > > > bool do_numainfo; > > > do_numainfo = mem_cgroup_event_ratelimit(memcg, > > > MEM_CGROUP_TARGET_NUMAINFO); > > > #endif > > > do_softlimit = mem_cgroup_event_ratelimit(memcg, > > > MEM_CGROUP_TARGET_SOFTLIMIT); > > > preempt_enable(); > > > > > > mem_cgroup_threshold(memcg); > > > > > > > Ah. please see linux-next and rebase onto that. > > The patchset is on top of next-20111222. Have I missed something? > Ah, ok. my mistake. Sorry. Acked-by: KAMEZAWA Hiroyuki -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org