From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx134.postini.com [74.125.245.134]) by kanga.kvack.org (Postfix) with SMTP id 7DEE86B004F for ; Mon, 26 Dec 2011 01:26:49 -0500 (EST) Received: from m1.gw.fujitsu.co.jp (unknown [10.0.50.71]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id A6E833EE0B6 for ; Mon, 26 Dec 2011 15:26:47 +0900 (JST) Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 8946F45DE5D for ; Mon, 26 Dec 2011 15:26:47 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 6FCED45DE5A for ; Mon, 26 Dec 2011 15:26:47 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 5F7B51DB8053 for ; Mon, 26 Dec 2011 15:26:47 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.240.81.145]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 0F6AD1DB804F for ; Mon, 26 Dec 2011 15:26:47 +0900 (JST) Date: Mon, 26 Dec 2011 15:25:31 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH 1/6] memcg: fix unused variable warning Message-Id: <20111226152531.e0335ec4.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <1324695619-5537-1-git-send-email-kirill@shutemov.name> References: <1324695619-5537-1-git-send-email-kirill@shutemov.name> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, Balbir Singh , Michal Hocko , Johannes Weiner On Sat, 24 Dec 2011 05:00:14 +0200 "Kirill A. Shutemov" wrote: > From: "Kirill A. Shutemov" > > mm/memcontrol.c: In function ‘memcg_check_events’: > mm/memcontrol.c:784:22: warning: unused variable ‘do_numainfo’ [-Wunused-variable] > > Signed-off-by: Kirill A. Shutemov Hmm ? Doesn't this fix cause a new Warning ? mm/memcontrol.c: In function ?memcg_check_events?: mm/memcontrol.c:789: warning: ISO C90 forbids mixed declarations and code Thanks, -Kame > --- > mm/memcontrol.c | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index d643bd6..a5e92bd 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -781,14 +781,15 @@ static void memcg_check_events(struct mem_cgroup *memcg, struct page *page) > /* threshold event is triggered in finer grain than soft limit */ > if (unlikely(mem_cgroup_event_ratelimit(memcg, > MEM_CGROUP_TARGET_THRESH))) { > - bool do_softlimit, do_numainfo; > + bool do_softlimit; > > - do_softlimit = mem_cgroup_event_ratelimit(memcg, > - MEM_CGROUP_TARGET_SOFTLIMIT); > #if MAX_NUMNODES > 1 > + bool do_numainfo; > do_numainfo = mem_cgroup_event_ratelimit(memcg, > MEM_CGROUP_TARGET_NUMAINFO); > #endif > + do_softlimit = mem_cgroup_event_ratelimit(memcg, > + MEM_CGROUP_TARGET_SOFTLIMIT); > preempt_enable(); > > mem_cgroup_threshold(memcg); > -- > 1.7.7.3 > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org