Re: [PATCH V2 1/6] drivers/staging/ramster: cluster/messaging foundation

[Greg KH <greg@kroah.com>]

On Thu, Dec 22, 2011 at 07:50:50AM -0800, Dan Magenheimer wrote:
> >From 93c00028709a5d423de77a2fc24d32ec10eca443 Mon Sep 17 00:00:00 2001
> From: Dan Magenheimer <dan.magenheimer@oracle.com>
> Date: Wed, 21 Dec 2011 14:01:54 -0700
> Subject: [PATCH V2 1/6] drivers/staging/ramster: cluster/messaging foundation

Why duplicate this in the email body?  That forces me to edit the
patches and remove them, please use git send-email...

> Copy cluster subdirectory from ocfs2.  These files implement
> the basic cluster discovery, mapping, heartbeat / keepalive, and
> messaging ("o2net") that ramster requires for internode communication.
> Note: there are NO ramster-specific changes yet; this commit
> does NOT pass checkpatch since the copied source files do not.

Why are you copying the files, and not just exporting the symbols you
need/want to use here?  Are you going to be able to properly track
keeping this code in sync?

Same goes for your other patch in this series that copies code, why do
that?  Are there goals to eventually not have duplicated code?  If so,
what are they, and why not mention them?

thanks,

greg k-h

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>