From: Johannes Weiner <hannes@cmpxchg.org>
To: kosaki.motohiro@gmail.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Minchan Kim <minchan.kim@gmail.com>,
Caspar Zhang <caspar@casparzhang.com>,
Andrew Morton <akpm@linux-foundation.org>,
Stephen Wilson <wilsons@start.ca>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH] [v2] mempolicy: refix mbind_range() vma issue
Date: Tue, 20 Dec 2011 20:28:50 +0100 [thread overview]
Message-ID: <20111220192850.GB3870@cmpxchg.org> (raw)
In-Reply-To: <1324405032-22281-1-git-send-email-kosaki.motohiro@gmail.com>
On Tue, Dec 20, 2011 at 01:17:10PM -0500, kosaki.motohiro@gmail.com wrote:
> From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>
> commit 8aacc9f550 (mm/mempolicy.c: fix pgoff in mbind vma merge) is
> slightly incorrect fix.
>
> Why? Think following case.
>
> 1. map 4 pages of a file at offset 0
>
> [0123]
>
> 2. map 2 pages just after the first mapping of the same file but with
> page offset 2
>
> [0123][23]
>
> 3. mbind() 2 pages from the first mapping at offset 2.
> mbind_range() should treat new vma is,
>
> [0123][23]
> |23|
> mbind vma
>
> but it does
>
> [0123][23]
> |01|
> mbind vma
>
> Oops. then, it makes wrong vma merge and splitting ([01][0123] or similar).
>
> This patch fixes it.
>
> [testcase]
> test result - before the patch
>
> case4: 126: test failed. expect '2,4', actual '2,2,2'
> case5: passed
> case6: passed
> case7: passed
> case8: passed
> case_n: 246: test failed. expect '4,2', actual '1,4'
>
> ------------[ cut here ]------------
> kernel BUG at mm/filemap.c:135!
> invalid opcode: 0000 [#4] SMP DEBUG_PAGEALLOC
>
> (snip long bug on messages)
>
> test result - after the patch
>
> case4: passed
> case5: passed
> case6: passed
> case7: passed
> case8: passed
> case_n: passed
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Minchan Kim <minchan.kim@gmail.com>
> CC: Caspar Zhang <caspar@casparzhang.com>
Looks good to me now, thanks.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Since this can corrupt virtual mappings and was released with 3.2, I
think we also want this:
Cc: stable@kernel.org [3.2.x]
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-12-20 19:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 16:55 [PATCH] " kosaki.motohiro
2011-12-12 11:20 ` Johannes Weiner
2011-12-20 18:17 ` [PATCH] [v2] " kosaki.motohiro
2011-12-20 19:28 ` Johannes Weiner [this message]
2011-12-20 23:37 ` Andrew Morton
2011-12-20 23:54 ` Johannes Weiner
2011-12-20 18:19 ` [PATCH] " KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111220192850.GB3870@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=caspar@casparzhang.com \
--cc=kosaki.motohiro@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=wilsons@start.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox